Skip to content

This is the code update for calling new Icepack. #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev/gfdl
Choose a base branch
from

Conversation

kshedstrom
Copy link
Contributor

The "main" branch as of Oct 24, 2024 adds the optional arguments
described here.

It uses the public icepack_step_ridge instead of the old interface,
which is now private. The code that was in Icepack's ridge_prep had
to be moved to the SIS2 side. There are two new options in the call to
icepack_step_ridge, telling it how much to do. To reproduce old answers,
both options should be set to False. On the Icepack side, they recommend
both being True, which will not only call the ridging code, but also put
a limiter on some ice fields (no negative thicknesses, etc.) and call
the rebin routine, which resets which ice is in which thickness category.

All three versions run for me (three because rebin depends on calling
the cleanup routine). I have promised some feedback if we later decide
to just pick one forever.

 The "main" branch as of Oct 24, 2024 adds the optional arguments
 described here.

 It uses the public icepack_step_ridge instead of the old interface,
 which is now private. The code that was in Icepack's ridge_prep had
 to be moved to the SIS2 side. There are two new options in the call to
 icepack_step_ridge, telling it how much to do. To reproduce old answers,
 both options should be set to False. On the Icepack side, they recommend
 both being True, which will not only call the ridging code, but also put
 a limiter on some ice fields (no negative thicknesses, etc.) and call
 the rebin routine, which resets which ice is in which thickness category.

 All three versions run for me (three because rebin depends on calling
 the cleanup routine). I have promised some feedback if we later decide
 to just pick one forever.
@kshedstrom
Copy link
Contributor Author

Icepack 1.5.0 has been released with this note:
NOTE: This version is not backwards compatible with earlier versions of Icepack due to changes in public interfaces. In addition, all answers are changed.

@MJHarrison-GFDL
Copy link
Contributor

MJHarrison-GFDL commented Nov 20, 2024 via email

@kshedstrom kshedstrom closed this Mar 7, 2025
@kshedstrom kshedstrom reopened this Mar 7, 2025
@theresa-cordero
Copy link

I am I correctly understanding that these code changes would mean users have to use an updated version of Icepack? And that the answers will change with the updated version of Icepack?

@theresa-cordero
Copy link

@MitchBushuk
Besides Kate in the regional Arctic domain, we thought that OM5 is the only other configuration using these Icepack options. Is that correct? Would it be okay for OM5 to change answers because of a change in the Icepack version?

@kshedstrom
Copy link
Contributor Author

This adds two flags:

To reproduce old answers, both options should be set to False.

Yes, you have to update Icepack.

@MitchBushuk
Copy link

Thanks @kshedstrom for your great work on this PR! Just to confirm, if the flags docleanup and dorebin are both set to False, this should reproduce old answers, correct?

Also, if these flags are set to True, does this change the model's ability to use the krdg_partic=1 and krdg_redist=1 options? The earlier version would crash with tiny negative thickness values when these options were set, but I wonder if the new cleanup routine fixes this.

@theresa-cordero it sounds like Kate's flags allow us to reproduce old answers, so we should be all set from an OM5 perspective.

@kshedstrom
Copy link
Contributor Author

Yes, I can reproduce old answers with the flags set to False.

I too was hoping that we can try the new ridging with Icepack doing the cleanup, but no, it didn't work for me.

marshallward
marshallward previously approved these changes Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants