-
Notifications
You must be signed in to change notification settings - Fork 49
This is the code update for calling new Icepack. #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/gfdl
Are you sure you want to change the base?
Conversation
The "main" branch as of Oct 24, 2024 adds the optional arguments described here. It uses the public icepack_step_ridge instead of the old interface, which is now private. The code that was in Icepack's ridge_prep had to be moved to the SIS2 side. There are two new options in the call to icepack_step_ridge, telling it how much to do. To reproduce old answers, both options should be set to False. On the Icepack side, they recommend both being True, which will not only call the ridging code, but also put a limiter on some ice fields (no negative thicknesses, etc.) and call the rebin routine, which resets which ice is in which thickness category. All three versions run for me (three because rebin depends on calling the cleanup routine). I have promised some feedback if we later decide to just pick one forever.
Icepack 1.5.0 has been released with this note: |
Thanks for your efforts Kate! We will test the various options.
On Tuesday, November 19, 2024, Kate Hedstrom ***@***.***> wrote:
Icepack 1.5.0 has been released with this note:
NOTE: This version is not backwards compatible with earlier versions of
Icepack due to changes in public interfaces. In addition, all answers are
changed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.<
…--
Matthew Harrison (he/him)
USDOC/NOAA/GFDL/Oceans&Cryosphere
|
I am I correctly understanding that these code changes would mean users have to use an updated version of Icepack? And that the answers will change with the updated version of Icepack? |
@MitchBushuk |
This adds two flags:
Yes, you have to update Icepack. |
Thanks @kshedstrom for your great work on this PR! Just to confirm, if the flags Also, if these flags are set to True, does this change the model's ability to use the @theresa-cordero it sounds like Kate's flags allow us to reproduce old answers, so we should be all set from an OM5 perspective. |
Yes, I can reproduce old answers with the flags set to False. I too was hoping that we can try the new ridging with Icepack doing the cleanup, but no, it didn't work for me. |
The "main" branch as of Oct 24, 2024 adds the optional arguments
described here.
It uses the public icepack_step_ridge instead of the old interface,
which is now private. The code that was in Icepack's ridge_prep had
to be moved to the SIS2 side. There are two new options in the call to
icepack_step_ridge, telling it how much to do. To reproduce old answers,
both options should be set to False. On the Icepack side, they recommend
both being True, which will not only call the ridging code, but also put
a limiter on some ice fields (no negative thicknesses, etc.) and call
the rebin routine, which resets which ice is in which thickness category.
All three versions run for me (three because rebin depends on calling
the cleanup routine). I have promised some feedback if we later decide
to just pick one forever.