Skip to content

Replace HasFlueOrChimneyInConditionedSpace input #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Replace HasFlueOrChimneyInConditionedSpace input #1778

wants to merge 5 commits into from

Conversation

@shorowit
Copy link
Contributor

@shorowit shorowit commented Jul 15, 2024

Pull Request Description

Closes #1687.

TODO:

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added enhancement New feature or request refactor labels Jul 15, 2024
@shorowit shorowit self-assigned this Jul 15, 2024
@shorowit shorowit marked this pull request as draft July 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@shorowit shorowit

Labels

enhancement New feature or request refactor

Projects

OpenStudio-HPXML
Status: Blocker/On Hold

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace HasFlueOrChimneyInConditionedSpace input with, e.g., AtmosphericBurner elements

2 participants

@shorowit