Change inverter datasheet callbacks to allow for operation power consumption #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow for user input of power consumption for both manufacturer and weighted efficiencies
sjanzou
approved these changes
Apr 11, 2025
| "\treturn ?${inv_ds_eff_type}", | ||
| "[ 0.0, ", | ||
| "0.008*${inv_ds_paco}]; };", | ||
| "\treturn 0.008*${inv_ds_paco}; \r", |
There was a problem hiding this comment.
The results look more curve-like now!
cpaulgilman
added
the
added to release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Change callbacks for inverter datasheet to allow user to input inverter daytime power consumption for weighted efficiency and manufacturer efficiency
-Previously, this was disabled for weighted efficiency
-This is changed to be a better fit for the Sandia inverter model
-Closes NREL/ssc#1314