Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] demo_cp_ct_surfaces not installed correctly from PyPI. #1094

Closed
misi9170 opened this issue Apr 3, 2025 · 2 comments
Closed

[BUG] demo_cp_ct_surfaces not installed correctly from PyPI. #1094

misi9170 opened this issue Apr 3, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@misi9170
Copy link
Collaborator

misi9170 commented Apr 3, 2025

It appears that Cp/Ct surface data that was introduced in #832 is not correctly installed from PyPI. For example, automated tests in FLASC are failing because this data is missing.

Possibly, we need to add the turbine_library/demo_cp_ct_surfaces/ data to the [tool.setuptools.package-data] section of the pyproject.toml?

Steps to reproduce

Create a new conda environment, pip install FLORIS, and try to instantiate a FlorisModel

conda create --name temp python
conda activate temp
pip install floris

Then, in a python terminal with the temp environment activated

from floris import FlorisModel
fmodel = FlorisModel("defaults")

This causes an error:

FileNotFoundError: [Errno 2] No such file or directory: '/opt/miniconda3/envs/temp/lib/python3.13/site-packages/floris/turbine_library/demo_cp_ct_surfaces/nrel_5MW_demo_cp_ct_surface.npz'

Notes

I think this should not affect users that clone directly from github; just those installing Floris from PyPI. Current workaround is to specify pip install floris==4.3 to stay on the previous Floris version before the bug was introduced.

@misi9170
Copy link
Collaborator Author

misi9170 commented Apr 7, 2025

Should be addressed by #1095. I'll know for sure once we release 4.4.1 and will close this PR at that time.

@misi9170
Copy link
Collaborator Author

misi9170 commented Apr 7, 2025

Release 4.4.1 fixes this issue with the inclusion of #1095.

@misi9170 misi9170 closed this as completed Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant