-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Add demo_cp_ct_surface location to data files. #1095
base: main
Are you sure you want to change the base?
Conversation
You can test this locally by doing |
…urfaces from package data.
@rafmudaf 's testing suggestion did work locally. I'm now testing removing the |
1c01ae4
to
db65d0f
Compare
0d522f3
to
67ab441
Compare
Ok, after a lot of digging, @rafmudaf and I found and fixed a couple of other issues:
|
Thanks for all the digging here @misi9170. Also, I appreciate the status updates and documentation you've included in this PR. Nicely done. |
I believe this should address #1094 . I'm not sure what the best way to test the fix is, though, short of merging this and creating a new release (UPDATE: Read comments below for how to test locally).
UPDATE:
To avoid this type of bug being introduced again, as well as adding the missing data to the
[tool.setuptools.package-data]
list of pyproject.toml, this PR:-e
flag