-
Notifications
You must be signed in to change notification settings - Fork 171
Drop support for python 3.9 #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
At this stage, I have updated the check-working-examples workflow to include mac and windows. However, this is causing a bit of a headache, because there are a number of bash commands that are OS-specific and are currently not working. We could consider running tests on mac, windows, and ubuntu, but only running examples on ubuntu. This was the approach taken in #953. |
I love the evolution of the commit messages. YOLO force-pushes coming soon :) |
Haha nothing like pushing changes in a shell language I don't use to see what works! |
…untu w/ oldest support python only
db5dec1
to
680b92c
Compare
After some back and forth and trying different things, we have decided to simplify the workflows while providing some coverage across OSs:
|
I've now also removed most
still require this This currently affects two files, where I've left the Alternatively, the explicit return type hints could be removed in these locations, which would free us up to remove the |
I think this is ok if it is what it is, but nice to have a bunch of them removed, thanks @misi9170 ! |
Following #1078 , and based on comments #953 (comment) and #951 (comment), this PR drops support for python version 3.9. This should remain as an open pull request until we feel that it is appropriate to drop support as python 3.9 nears end-of-life.
This PR also:
Add example checks for mac-os and windows as well as ubuntu (currently failing!)Runs examples check on ubuntu only, using the oldest supported python version (3.10)Add testing for the yet-to-be released python 3.14EDIT: not released so installation fails__future__ import annotations
needed to make type hinting compatible with python 3.9. This is not possible everywhere: see comments below.Begins using theEDIT: After discussion, decided against a concerted change to switch case since it is not super common in python yet.match
/case
structureOpen questions:
python-version: "3.13"
topython-version: "3.x"
in the deploy-book workflow to allow this to float up with the latest python releases?