Skip to content

NMC Battery Life Bug: Fix small near-zero value in dq_relative_li1 #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

NMC Battery Life Bug: Fix small near-zero value in dq_relative_li1 #1310

merged 2 commits into from
Apr 7, 2025
+4 −4

Conversation

dguittet
Copy link
Collaborator

@dguittet dguittet commented Apr 4, 2025

Fix #1171

@dguittet
fix small near-zero value in dq_relative_li1

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
df5ebe0
@dguittet dguittet requested a review from brtietz April 4, 2025 15:56
@dguittet dguittet added this to the SAM Spring 2025 Release milestone Apr 4, 2025
@brtietz
See if std::abs solves cross platform issue
Loading
Loading status checks…
d70c7ad
brtietz
brtietz approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@coveralls
Copy link

coveralls commented Apr 5, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14274948260

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.709%
Totals Coverage Status
Change from base Build 14267854697: 0.0%
Covered Lines: 64322
Relevant Lines: 117572
💛 - Coveralls

@sjanzou sjanzou merged commit a3305e8 into develop Apr 7, 2025
10 checks passed
@sjanzou sjanzou deleted the ssc_1171 branch April 7, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brtietz brtietz

Assignees
No one assigned
Labels
added to release notes battery
Projects
None yet
Milestone
SAM Spring 2025 Release
Development

Successfully merging this pull request may close these issues.

Zeroes in output
5 participants
@dguittet @coveralls @brtietz @sjanzou @cpaulgilman