Remove quoutes around database flags #215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the single qoutes around {{ flag }} => {{ value }} since the config does not work with them in place. According to https://github.com/MISP/MISP/blob/2.5/app/Config/database.default.php the database flags should be without quoutes.
Note that MISP2.5 requres the flag
'flags' => [
PDO::ATTR_STRINGIFY_FETCHES => true
]
to have the API work as expected so this might be hardcoded in? I dont know if 2.4 compability is still needed.
|
This has now been tested, works as intended. Ie the results from api requests are stringified if you supply that flag per misp project instructions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I have not yet tested this due to lack of proper environment, will try to do so ASAP if you cant.
Removed the single qoutes around {{ flag }} => {{ value }} since the config does not work with them in place. According to https://github.com/MISP/MISP/blob/2.5/app/Config/database.default.php the database flags should be without quoutes.
Note that MISP2.5 requres the flag
'flags' => [
PDO::ATTR_STRINGIFY_FETCHES => true
]
to have the API work as expected so this might be hardcoded in? I dont know if 2.4 compability is still needed.