Skip to content

RO-2773: Endringer knytta til maks bredde på sider #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
:host {
display: block;
margin-left: 0;
margin-right: 0;
max-width: var(--desktop-max-width);
margin: 0 auto;
margin-top: 16px;
background-color: white;
box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
background: var(--background-color-menu);
border-radius: var(--border-radius-large);
--ion-grid-padding: 32px;
max-width: var(--desktop-max-width);
}

.profile-icon {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
ion-col {
max-width: 600px;
max-width: var(--desktop-max-width);
margin: 0 auto;
}

ion-grid {
max-width: var(--form-max-width);
margin: 0 auto;
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ion-list {
}

.content-wrapper {
max-width: 960px;
max-width: var(--form-max-width);
margin: auto;

ion-item {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
:host {
max-width: 960px;
max-width: var(--desktop-max-width);
margin: auto;
display: flex;
flex-wrap: wrap;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
ion-item-divider {
margin-bottom: 10px;
}

ion-list {
width: 100%;
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<!-- A list of observations sent to server -->
<ng-container *ngIf="myRegistrations; else skeleton">
<ion-item-divider no-border>
<ion-grid class="ion-no-padding ion-no-margin">
Expand Down
34 changes: 18 additions & 16 deletions src/app/pages/my-observations/my-observations.page.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,23 @@
</ion-toolbar>
</ion-header>
<ion-content>
<app-refresh-with-cancel [refreshFunc]="refreshFunc"></app-refresh-with-cancel>
<app-draft-list (isEmpty)="refreshDraftEmptyState($event)"></app-draft-list>
<app-sent-list (isEmpty)="refreshSentEmptyState($event)"></app-sent-list>
<ion-grid *ngIf="draftIsEmpty && sentRegistrationsIsEmpty" class="full-grid">
<ion-row class="full-grid-row">
<ion-col class="ion-text-center ion-align-self-center">
<svg-icon src="/assets/images/empty-states/no-my-observations.svg"></svg-icon>
</ion-col>
</ion-row>
<ion-row class="full-grid-row">
<ion-col class="ion-text-center ion-margin-horizontal">
<h2>{{ "MY_OBSERVATIONS.NO_OBSERVATIONS" | translate }}</h2>
<h3 class="ion-text-wrap">{{ "MY_OBSERVATIONS.NO_OBSERVATIONS_TEXT" | translate }}</h3>
</ion-col>
</ion-row>
</ion-grid>
<main>
<app-refresh-with-cancel [refreshFunc]="refreshFunc"></app-refresh-with-cancel>
<app-draft-list (isEmpty)="refreshDraftEmptyState($event)"></app-draft-list>
<app-sent-list (isEmpty)="refreshSentEmptyState($event)"></app-sent-list>
<ion-grid *ngIf="draftIsEmpty && sentRegistrationsIsEmpty" class="full-grid">
<ion-row class="full-grid-row">
<ion-col class="ion-text-center ion-align-self-center">
<svg-icon src="/assets/images/empty-states/no-my-observations.svg"></svg-icon>
</ion-col>
</ion-row>
<ion-row class="full-grid-row">
<ion-col class="ion-text-center ion-margin-horizontal">
<h2>{{ "MY_OBSERVATIONS.NO_OBSERVATIONS" | translate }}</h2>
<h3 class="ion-text-wrap">{{ "MY_OBSERVATIONS.NO_OBSERVATIONS_TEXT" | translate }}</h3>
</ion-col>
</ion-row>
</ion-grid>
</main>
</ion-content>
<app-add-menu></app-add-menu>
5 changes: 5 additions & 0 deletions src/app/pages/my-observations/my-observations.page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@ ion-spinner {
margin-top: 10px;
margin-bottom: 10px;
}

main {
max-width: var(--desktop-max-width);
margin: 0 auto;
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
}

ion-row {
max-width: 960px;
max-width: var(--desktop-max-width);
margin: 10px auto;
gap: 10px;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
}

ion-row {
max-width: 960px;
max-width: var(--desktop-max-width);
margin: 10px auto;
gap: 10px;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
:host {
display: block;
height: 100%;
--max-width: var(--list-search-max-width, 960px);
}

ion-content {
Expand All @@ -14,7 +13,7 @@ ion-content::part(scroll) {
}

.list-header {
max-width: var(--max-width);
max-width: var(--desktop-max-width);
margin: 0 auto;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,17 @@
display: block;
height: 100%;
width: 100%;

--max-width: var(--list-search-max-width, 960px);
}

.list-header {
max-width: var(--max-width);
max-width: var(--desktop-max-width);
margin: 0 auto;
}

.list {
height: 100%;
width: 100%;
max-width: var(--max-width);
max-width: var(--desktop-max-width);
margin: 0 auto;
}

Expand Down
98 changes: 50 additions & 48 deletions src/app/pages/user-settings/user-settings.page.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,57 +7,59 @@
</ion-toolbar>
</ion-header>
<ion-content class="ion-padding" *ngIf="userSettings">
<ion-list lines="full">
<!-- App version -->
<ion-item *ngIf="version" (click)="versionClick()">
<ion-label position="stacked" color="medium" class="ion-text-uppercase"
>{{ "SETTINGS.APP_VERSION" | translate }}
</ion-label>
<ion-text class="ion-align-self-start build-version">
{{ version.version }} ({{ version.buildNumber }})
</ion-text>
<ion-text class="build-rev ion-align-self-start" color="medium">
{{ version.revision }} - {{ version.date | formatDate | async }}
</ion-text>
</ion-item>
<main>
<ion-list lines="full">
<!-- App version -->
<ion-item *ngIf="version" (click)="versionClick()">
<ion-label position="stacked" color="medium" class="ion-text-uppercase"
>{{ "SETTINGS.APP_VERSION" | translate }}
</ion-label>
<ion-text class="ion-align-self-start build-version">
{{ version.version }} ({{ version.buildNumber }})
</ion-text>
<ion-text class="build-rev ion-align-self-start" color="medium">
{{ version.revision }} - {{ version.date | formatDate | async }}
</ion-text>
</ion-item>

<!-- App mode -->
<app-select
[(selectedValue)]="userSettings.appMode"
[options]="appModeOptions"
(selectedValueChange)="updateSettings()"
[showReset]="false"
label="SETTINGS.APPMODE"
></app-select>
<!-- App mode -->
<app-select
[(selectedValue)]="userSettings.appMode"
[options]="appModeOptions"
(selectedValueChange)="updateSettings()"
[showReset]="false"
label="SETTINGS.APPMODE"
></app-select>

<!-- Use high detail maps -->
<ion-item>
<ion-label> {{ "SETTINGS.USE_RETINA_MAP" | translate }} </ion-label>
<ion-toggle slot="end" [(ngModel)]="userSettings.useRetinaMap" (ngModelChange)="updateSettings()"> </ion-toggle>
</ion-item>
<!-- Use high detail maps -->
<ion-item>
<ion-label> {{ "SETTINGS.USE_RETINA_MAP" | translate }} </ion-label>
<ion-toggle slot="end" [(ngModel)]="userSettings.useRetinaMap" (ngModelChange)="updateSettings()"> </ion-toggle>
</ion-item>

<!-- GPS Debug -->
<ion-item *ngIf="userSettings.featureToggleDeveloperMode">
<ion-label> GPS debug </ion-label>
<ion-toggle slot="end" [(ngModel)]="userSettings.featureToggeGpsDebug" (ngModelChange)="updateSettings()">
</ion-toggle>
</ion-item>
</ion-list>
<!-- GPS Debug -->
<ion-item *ngIf="userSettings.featureToggleDeveloperMode">
<ion-label> GPS debug </ion-label>
<ion-toggle slot="end" [(ngModel)]="userSettings.featureToggeGpsDebug" (ngModelChange)="updateSettings()">
</ion-toggle>
</ion-item>
</ion-list>

<ion-list lines="none">
<ion-button expand="block" [disabled]="isUpdating" (click)="updateDropdowns()">
<ion-icon slot="start" name="refresh"></ion-icon>
{{ "SETTINGS.UPDATE_DROPDOWNS" | translate }}
</ion-button>
@if (isNativePlatform) {
<ion-button expand="block" [disabled]="isUpdating" (click)="sendLogs()">
<ion-icon slot="start" name="mail-outline"></ion-icon>
{{ "SETTINGS.SEND_LOGS" | translate }}
<ion-list lines="none">
<ion-button expand="block" [disabled]="isUpdating" (click)="updateDropdowns()">
<ion-icon slot="start" name="refresh"></ion-icon>
{{ "SETTINGS.UPDATE_DROPDOWNS" | translate }}
</ion-button>
}
<ion-button class="reset-button" color="danger" expand="block" [disabled]="isUpdating" (click)="confirmReset()">
<ion-icon slot="start" name="medkit"></ion-icon>
{{ "SETTINGS.RESET" | translate }}
</ion-button>
</ion-list>
@if (isNativePlatform) {
<ion-button expand="block" [disabled]="isUpdating" (click)="sendLogs()">
<ion-icon slot="start" name="mail-outline"></ion-icon>
{{ "SETTINGS.SEND_LOGS" | translate }}
</ion-button>
}
<ion-button class="reset-button" color="danger" expand="block" [disabled]="isUpdating" (click)="confirmReset()">
<ion-icon slot="start" name="medkit"></ion-icon>
{{ "SETTINGS.RESET" | translate }}
</ion-button>
</ion-list>
</main>
</ion-content>
5 changes: 5 additions & 0 deletions src/app/pages/user-settings/user-settings.page.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,8 @@ ion-item {
}
}
}

main {
max-width: var(--desktop-max-width);
margin: 0 auto;
}
6 changes: 6 additions & 0 deletions src/global.scss
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@
--ion-color-danger-contrast-rgb: 255, 255, 255;
--ion-color-danger-shade: #b40000;
--ion-color-danger-tint: #d11a1a;

/*Setter maks bredde på innhold på store skjermer. Foreløpig bør den brukes på hver side, men
vi kan vurdere å ha en felles kilde for layoutens maksimale bredde som settes et sted. */
--desktop-max-width: 960px;
--form-max-width: 650px;
}

html {
Expand Down Expand Up @@ -954,6 +959,7 @@ ion-select-popover ion-list ion-item ion-radio {
// These styles needs to be applied globally according to ionic docs: https://ionicframework.com/docs/api/popover#styling
ion-popover.select-popover {
--width: fit-content(90vw);
--min-width: 150px;
--max-width: 90vw;
}

Expand Down
Loading