Skip to content

Update conda configs for v0.5 release#176

Merged
scal444 merged 1 commit into
NVIDIA-Digital-Bio:mainfrom
scal444:bump_conda_versions
May 18, 2026
Merged

Update conda configs for v0.5 release#176
scal444 merged 1 commit into
NVIDIA-Digital-Bio:mainfrom
scal444:bump_conda_versions

Conversation

@scal444
Copy link
Copy Markdown
Collaborator

@scal444 scal444 commented May 18, 2026

Reduced to 3 configs, one for each supported cuda

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 18, 2026

Greptile Summary

This PR updates the conda-build CI matrix for the v0.5 release, trimming it from five configurations down to three — one per supported CUDA version (12.6, 12.9, 13.0). The config strings are also updated with more complete variant identifiers that now include explicit compiler and Boost library version components.

  • Removed two intermediate Python/rdkit combinations on CUDA 12.9; the matrix now covers min/mid/max combos rather than every python × rdkit × cuda permutation.
  • New config filenames (e.g. linux_64_c_compiler_version13…) include c_compiler_version, cxx_compiler_version, and libboost_* pins that were absent in the old strings, reflecting feedstock schema changes.

Confidence Score: 4/5

Safe to merge; the change is a straightforward matrix reduction with updated config identifiers, and the rest of the workflow is untouched.

The matrix trimming and new config strings look intentional and consistent with the stated goal. The only open question is whether the matrix.python labels still accurately reflect the Python version embedded in each new config file, since the Python component was dropped from the config filename. If the labels are wrong, artifact names are misleading but build correctness is unaffected.

.github/workflows/conda-build.yml — worth confirming the Python version actually built by each new config matches the matrix.python label used in artifact names.

Important Files Changed

Filename Overview
.github/workflows/conda-build.yml Matrix reduced from 5 to 3 entries (one per CUDA version); config strings updated to include compiler and boost version components but no longer encode Python version in the filename.

Reviews (1): Last reviewed commit: "Update conda configs for v0.5 release" | Re-trigger Greptile

Comment thread .github/workflows/conda-build.yml
@scal444 scal444 requested a review from evasnow1992 May 18, 2026 16:28
@scal444
Copy link
Copy Markdown
Collaborator Author

scal444 commented May 18, 2026

@evasnow1992 all of our CI will fail until this one gets in

rdkit: "2025.3.2"
cuda: "12.9"
config: linux_64_c_stdlib_version2.17cuda_compiler_version12.9librdkit_dev2025.3.2python3.11.____cpython
rdkit: "2025.3.3"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor point. Our README still contains the stale statement: “nvMolKit v0.2.0 supports RDKit 2024.09.6 and 2025.03.1. To install:”. We may want to update both the nvMolKit version and the new minimum RDKit version (2025.3.3).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, missed that in the version bump PR, will add in a followup

Copy link
Copy Markdown
Collaborator

@evasnow1992 evasnow1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks!

@scal444 scal444 merged commit 440fad0 into NVIDIA-Digital-Bio:main May 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants