Fix omni3 CLI test collection and restore super3/omni3 command registration#294
Open
temujinkz wants to merge 1 commit into
Open
Fix omni3 CLI test collection and restore super3/omni3 command registration#294temujinkz wants to merge 1 commit into
temujinkz wants to merge 1 commit into
Conversation
tests/recipes/omni3/test_cli.py still imported the omni3 build dispatcher that was removed when container builds moved to the shared kit slurm build command, so pytest died at collection. Drop the stale build tests and keep the job-name and app-structure checks. Getting the file running again exposed a second problem: super3's data prep group still imports META/rl from the rl module that became a subgroup package. That import error silently drops both super3 and omni3 from the CLI because group registration swallows failures. Mount rl_app the way omni3 does. Fixes NVIDIA-NeMo#284 Signed-off-by: temujinkz <ttalkenov@gmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #284
The test file imported the omni3 build dispatcher that was removed when container builds moved to the shared
nemotron kit slurm buildcommand, so the whole file died at collection. Dropped the stale build tests and kept the job-name and app-structure tests that still point at real code.Getting the file running again turned up a second bug: super3's data prep group still imports
META, rlfrom the rl module that became a subgroup package. That import error silently knocks bothsuper3andomni3out of the CLI, since group registration swallows failures. Mountingrl_appthe way omni3 does fixes both groups.Verified on Python 3.12 with full deps: the file goes from a collection error to 20 passed, and
nemotron super3 data prep --helpandnemotron omni3 --helpboth show their commands again. Thanks @andrewwhitecdw for the detailed report.