-
Notifications
You must be signed in to change notification settings - Fork 20
feat(studio): Transform through Data Designer Processors #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
web/packages/studio/src/api/datasets/useDatasetFileTransform.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { filesUploadFile } from '@nemo/sdk/generated/platform/api'; | ||
| import { useDatasetFileTransform } from '@studio/api/datasets/useDatasetFileTransform'; | ||
| import { TestProviders } from '@studio/tests/util/TestProviders'; | ||
| import { renderHook } from '@testing-library/react'; | ||
|
|
||
| vi.mock('@nemo/sdk/generated/platform/api', () => ({ | ||
| filesUploadFile: vi.fn().mockResolvedValue({ path: 'data.jsonl' }), | ||
| })); | ||
|
|
||
| vi.mock('@studio/api/datasets/invalidateDatasetCaches', () => ({ | ||
| invalidateDatasetCaches: vi.fn(), | ||
| })); | ||
|
|
||
| const uploadMock = vi.mocked(filesUploadFile); | ||
|
|
||
| const baseVariables = { | ||
| workspace: 'default', | ||
| datasetName: 'test', | ||
| filepath: 'data.jsonl', | ||
| template: { id: '{{ task_id }}' }, | ||
| fileContent: '{"task_id":"a1"}', | ||
| }; | ||
|
|
||
| const renderTransform = () => | ||
| renderHook(() => useDatasetFileTransform({}), { wrapper: TestProviders }); | ||
|
|
||
| describe('useDatasetFileTransform', () => { | ||
| beforeEach(() => { | ||
| uploadMock.mockClear(); | ||
| }); | ||
|
|
||
| it('uploads the remapped rows for a JSONL file', async () => { | ||
| const { result } = renderTransform(); | ||
|
|
||
| await result.current.mutateAsync(baseVariables); | ||
|
|
||
| expect(uploadMock).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| it('gives every row its own identifier for a generated column', async () => { | ||
| const { result } = renderTransform(); | ||
|
|
||
| await result.current.mutateAsync({ | ||
| ...baseVariables, | ||
| template: { id: '{{ row_id }}' }, | ||
| fileContent: '{"a":1}\n{"a":2}', | ||
| generatedIdColumn: 'row_id', | ||
| }); | ||
|
|
||
| const blob = uploadMock.mock.calls[0][3] as Blob; | ||
| const ids = (await blob.text()).split('\n').map((line) => JSON.parse(line).id); | ||
| expect(new Set(ids).size).toBe(2); | ||
| // A full UUID, not a truncated slice — the transform can run over large files. | ||
| expect(ids[0]).toMatch(/^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/); | ||
| }); | ||
|
|
||
| it('does not upload anything when the file has no rows', async () => { | ||
| const { result } = renderTransform(); | ||
|
|
||
| await expect( | ||
| result.current.mutateAsync({ ...baseVariables, fileContent: ' \n ' }) | ||
| ).rejects.toThrow(/No rows could be read/); | ||
|
|
||
| expect(uploadMock).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('does not upload anything when every row fails to parse', async () => { | ||
| // `parseFileContent` logs each unparseable line. | ||
| const warn = vi.spyOn(console, 'warn').mockImplementation(() => {}); | ||
| const { result } = renderTransform(); | ||
|
|
||
| await expect( | ||
| result.current.mutateAsync({ ...baseVariables, fileContent: 'not json at all' }) | ||
| ).rejects.toThrow(/could not be parsed/); | ||
|
|
||
| expect(uploadMock).not.toHaveBeenCalled(); | ||
| warn.mockRestore(); | ||
| }); | ||
|
|
||
| it('does not upload a partially parsed file', async () => { | ||
| const warn = vi.spyOn(console, 'warn').mockImplementation(() => {}); | ||
| const { result } = renderTransform(); | ||
|
|
||
| await expect( | ||
| result.current.mutateAsync({ | ||
| ...baseVariables, | ||
| fileContent: '{"task_id":"a1"}\nnot json at all\n{"task_id":"a2"}', | ||
| }) | ||
| ).rejects.toThrow(/1 line\(s\) could not be parsed/); | ||
|
|
||
| expect(uploadMock).not.toHaveBeenCalled(); | ||
| warn.mockRestore(); | ||
| }); | ||
|
|
||
| it('refuses to overwrite a file that is not JSONL', async () => { | ||
| const { result } = renderTransform(); | ||
|
|
||
| await expect( | ||
| result.current.mutateAsync({ | ||
| ...baseVariables, | ||
| filepath: 'data.csv', | ||
| fileContent: 'task_id\na1', | ||
| }) | ||
| ).rejects.toThrow(/Only JSONL files/); | ||
|
|
||
| expect(uploadMock).not.toHaveBeenCalled(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.