fix(sdk): add [project.urls] to nemo-platform wrapper distribution - #1512
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe package metadata now defines URLs for the project homepage, documentation, and source repository. ChangesProject metadata
Merge Risk: ⚪ Minimal · up to This change adds PyPI project links without affecting runtime behavior, and no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Published PyPI wheel currently has `info.project_urls == null` and no `home_page`, so the pypi.org/project/nemo-platform/ sidebar shows no Homepage / Documentation / Source links. Users cannot navigate from PyPI to the docs site or the GitHub repo. Sister distribution nemo-platform-plugin already sets these; mirror the same pattern for the main wrapper. Documentation points to the public docs site (docs.nvidia.com/nemo-platform) rather than an in-repo folder, matching where users actually land from the CLI/PyPI. Bug Tracker was omitted per review on the original fork PR. Signed-off-by: Jinxiang Guo <jinxiang@nvidia.com> Signed-off-by: Glody Guo <jinxiang@nvidia.com>
27c6b27 to
f3c3ea5
Compare
Summary
Published PyPI wheel currently has
info.project_urls == nulland nohome_page, so the pypi.org/project/nemo-platform/ sidebar shows no Project links section. Users landing on PyPI cannot navigate to the docs site or the GitHub repo.Sister distribution
nemo-platform-pluginalready sets these; this mirrors that pattern on the main wrapper.Documentationpoints at the public docs site.Bug Trackeris omitted per review on the original fork PR.This recreates fork PR #1475 as a same-repo branch so GitHub Actions can use org Docker Hub secrets.
Changes
[project.urls](Homepage,Documentation,Source) topackages/nemo_platform/pyproject.tomlType of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
origin/main(b2ba47187) so CI runs in the canonical repo.Signed-off-by: Jinxiang Guo <jinxiang@nvidia.com>matches commit author.[project.urls]lines (no unrelatedpyproject.tomlchurn).uv run pre-commit run -awas not rerun for this metadata-only replay; GitHub CI on the same-repo branch is the gate.Summary by CodeRabbit