docs(home): link Harbor first-use to harborframework.com - #1513
Conversation
The landing page (docs/index.mdx) introduces "Harbor-backed eval suites" without defining Harbor or linking to a concept page. Readers unfamiliar with Harbor cannot orient themselves. Link the first use to the official Harbor website (https://www.harborframework.com/, tagline "A framework for evaluating and optimizing sandboxed agents and models"), matching its role in the NeMo Platform evaluation flow. Signed-off-by: Jinxiang Guo <jinxiang@nvidia.com> Signed-off-by: Glody Guo <jinxiang@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe agent evaluation documentation now links its Harbor reference to ChangesDocumentation Link
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized documentation change adds a first-use link for Harbor and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Summary
The landing page (
docs/index.mdx) introduces "Harbor-backed eval suites" without defining Harbor or linking to a concept page. Link the first use to https://www.harborframework.com/.This recreates fork PR #1476 as a same-repo branch so GitHub Actions can use org Docker Hub secrets.
Changes
docs/index.mdxnow links to https://www.harborframework.com/Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
origin/mainwith DCO sign-off.docs/index.mdx.uv run pre-commit run -awas not rerun; same-repo CI is the gate.Summary by CodeRabbit