Skip to content

docs(home): link Harbor first-use to harborframework.com - #1513

Merged
mckornfield merged 1 commit into
mainfrom
docs-home-harbor-link/glody
Aug 25, 2026
Merged

docs(home): link Harbor first-use to harborframework.com#1513
mckornfield merged 1 commit into
mainfrom
docs-home-harbor-link/glody

Conversation

@glody

@glody glody commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

The landing page (docs/index.mdx) introduces "Harbor-backed eval suites" without defining Harbor or linking to a concept page. Link the first use to https://www.harborframework.com/.

This recreates fork PR #1476 as a same-repo branch so GitHub Actions can use org Docker Hub secrets.

Changes

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with documentation updates
  • Documentation only
  • Contributor tooling or automation
  • CI, build, or test infrastructure

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification: one-line docs markdown link
  • Documentation updated for user-visible behavior
  • Documentation not applicable — justification:

Verification

  • Pull request title follows the repository's Conventional Commit format
  • Every commit includes an appropriate Signed-off-by: trailer
  • uv run pre-commit run -a passes, or any blocked checks are identified below
  • Targeted tests pass, or tests are marked not applicable above
  • No secrets, API keys, or credentials are included

Targeted validation:

  • Cherry-picked onto current origin/main with DCO sign-off.
  • Diff is the single Harbor link on docs/index.mdx.
  • Full local uv run pre-commit run -a was not rerun; same-repo CI is the gate.

Summary by CodeRabbit

  • Documentation
    • Added a hyperlink to the Harbor website in the agent evaluation capability description.

The landing page (docs/index.mdx) introduces "Harbor-backed eval suites"
without defining Harbor or linking to a concept page. Readers unfamiliar
with Harbor cannot orient themselves. Link the first use to the official
Harbor website (https://www.harborframework.com/, tagline "A framework
for evaluating and optimizing sandboxed agents and models"), matching
its role in the NeMo Platform evaluation flow.

Signed-off-by: Jinxiang Guo <jinxiang@nvidia.com>
Signed-off-by: Glody Guo <jinxiang@nvidia.com>
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1d6ca4f2-aa95-4c27-a41d-7c75b13e91c9

📥 Commits

Reviewing files that changed from the base of the PR and between b2ba471 and d5912fd.

📒 Files selected for processing (1)
  • docs/index.mdx

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The agent evaluation documentation now links its Harbor reference to https://www.harborframework.com/.

Changes

Documentation Link

Layer / File(s) Summary
Link the Harbor reference
docs/index.mdx
The evaluation bullet now links “Harbor” to the Harbor website.

Suggested reviewers: a2bondar

Merge Risk: ⚪ Minimal · up to d5912

This localized documentation change adds a first-use link for Harbor and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the documentation change: linking the first use of Harbor to harborframework.com.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs-home-harbor-link/glody

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 35321/45084 78.3% 62.8%
Integration Tests 21238/42859 49.5% 22.7%

@mckornfield
mckornfield added this pull request to the merge queue Aug 25, 2026
Merged via the queue into main with commit 5208bc7 Aug 25, 2026
61 checks passed
@mckornfield
mckornfield deleted the docs-home-harbor-link/glody branch August 25, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants