Skip to content

feat(studio): GRPO customization job details support [astd-388] - #1521

Merged
nakolean merged 3 commits into
mainfrom
nkolean/customizer-job-grpo
Aug 26, 2026
Merged

feat(studio): GRPO customization job details support [astd-388]#1521
nakolean merged 3 commits into
mainfrom
nkolean/customizer-job-grpo

Conversation

@nakolean

@nakolean nakolean commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-08-25.at.9.49.19.AM.mov

Summary

Related Issue

Changes

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with documentation updates
  • Documentation only
  • Contributor tooling or automation
  • CI, build, or test infrastructure

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Documentation updated for user-visible behavior
  • Documentation not applicable — justification:

Verification

  • Pull request title follows the repository's Conventional Commit format
  • Every commit includes an appropriate Signed-off-by: trailer
  • uv run pre-commit run -a passes, or any blocked checks are identified below
  • Targeted tests pass, or tests are marked not applicable above
  • No secrets, API keys, or credentials are included

Targeted validation:

Summary by CodeRabbit

  • New Features
    • Added GRPO customization overviews with reward charts, training-health diagnostics, progress metrics, and run-configuration details.
    • Added support for reward spreads, diagnostic thresholds, training and validation series, and informative empty states.
    • Enhanced range-band charts with per-series marker visibility and null-gap connection options.
  • Documentation
    • Clarified that reference lines outside explicit chart domains are omitted unless the domain is adjusted.
  • Tests
    • Added comprehensive coverage for GRPO panels, metrics, configurations, diagnostics, and chart behavior.

Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
@nakolean
nakolean requested review from a team as code owners August 25, 2026 15:49
@github-actions github-actions Bot added the feat label Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 34fd630d-e037-4172-9349-b53c7a4f6310

📥 Commits

Reviewing files that changed from the base of the PR and between 37e5208 and f52eccd.

📒 Files selected for processing (1)
  • web/packages/studio/src/util/customizations.test.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The customization overview now supports GRPO jobs with reward charts, training-health diagnostics, progress tiles, and GRPO run configuration. Metric utilities process telemetry and thresholds. RangeBand supports per-series markers and null connections. Fixtures, stories, and tests cover the new behavior.

Changes

GRPO customization overview

Layer / File(s) Summary
GRPO metric contracts and processing
web/packages/studio/src/types/customization.ts, web/packages/studio/src/util/grpoMetrics.ts, web/packages/studio/src/util/grpoMetrics.test.ts
Added extensible metric types, reward-series construction, diagnostic definitions, threshold-aware bounds, and utility tests.
GRPO customization utilities
web/packages/studio/src/util/customizations.tsx, web/packages/studio/src/util/customizations.test.ts
Added GRPO model, dataset, finetuning, summary-tile, run-configuration, and progress-tile handling.
RangeBand series controls
web/packages/studio/src/components/charts/RangeBand/types.ts, web/packages/studio/src/components/charts/RangeBand/chartLayers.tsx, web/packages/studio/src/components/charts/RangeBand/RangeBandGeometry.test.tsx, web/packages/common/src/components/charts/referenceLines.tsx
Added per-series marker and null-connection controls. Added reference-line domain documentation and coverage.
GRPO overview panels and integration
web/packages/studio/src/components/CustomizationOverview/*, web/packages/studio/src/mocks/customizer/customization-jobs.ts
Added reward and training-health panels, GRPO configuration rendering, job routing, fixtures, Storybook states, and integration tests.

Sequence Diagram(s)

sequenceDiagram
  participant CustomizationOverview
  participant grpoMetrics
  participant GrpoRewardPanel
  participant GrpoTrainingHealthPanel
  participant GrpoRunConfigPairs
  CustomizationOverview->>grpoMetrics: Build reward chart data and diagnostics
  grpoMetrics-->>CustomizationOverview: Return processed telemetry
  CustomizationOverview->>GrpoRewardPanel: Render rewards and progress
  CustomizationOverview->>GrpoTrainingHealthPanel: Render diagnostics
  CustomizationOverview->>GrpoRunConfigPairs: Render GRPO configuration
Loading

Suggested reviewers: a2bondar

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 17 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding GRPO customization job details support in Studio.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nkolean/customizer-job-grpo

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 35329/45091 78.3% 62.8%
Integration Tests 21048/42866 49.1% 22.3%

Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
@nakolean nakolean changed the title feat(studio): GRPO customization job details support feat(studio): GRPO customization job details support [astd-388] Aug 25, 2026
Comment thread web/packages/studio/src/util/customizations.test.ts Outdated
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
@nakolean
nakolean added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit 641a77a Aug 26, 2026
60 checks passed
@nakolean
nakolean deleted the nkolean/customizer-job-grpo branch August 26, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants