fix(customizer): include models SDK package in task images - #1537
Conversation
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
|
Started Platform-Deploy customizer-focused CI against this PR head (ebd8aa7): https://github.com/NVIDIA-NeMo/Platform-Deploy/actions/runs/32911839430 |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe PR adds ChangesModels workspace integration
Deployment resolution
Docker network resolution
GPU smoke-test isolation
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
|
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
|
Started fresh Platform-Deploy customizer-focused CI after the smoke-test update, against PR head 349da23: https://github.com/NVIDIA-NeMo/Platform-Deploy/actions/runs/32913311704 |
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
|
Pushed |
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
|
Pushed Started a new Platform-Deploy customizer-targeted run: https://github.com/NVIDIA-NeMo/Platform-Deploy/actions/runs/32922161305 Note: I also cancelled https://github.com/NVIDIA-NeMo/Platform-Deploy/actions/runs/32922109380 after catching an invalid full SHA dispatch with the same short prefix. |
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
Summary
Customizer task and training images were still missing generated SDK alias packages. After those image builds began passing, the Docker customizer E2E path exposed follow-on runtime issues in CPU-build smoke imports, deployment container networking, and deployments-plugin Docker endpoint readiness from inside a containerized Platform API.
Changes
packages/modelseditably alongside the SDK in customizer, automodel, unsloth, and RL task/training images.packages/modelsto the Unsloth and RL reduced workspace slices.NEMO_DEPLOYMENTS_DOCKER_NETWORKand compatibility withMODELS_DOCKER_NETWORK.endpoint_mode: networksupport so containerized Platform APIs probe/report deployment endpoints ashttp://<container-name>:<container-port>instead of loopback host ports.filesandmodelslazy resources so missing generated alias packages fail during image build.Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
uv run --frozen pytest tests/unit/test_docker_workspace_slices.py -v- 23 passeduv run ruff check tests/smoke_gpu/test_customizer_automodel.py tests/unit/test_docker_workspace_slices.py- passedmake docker-print TARGET=nmp-customizer- passeduv run --frozen pytest services/core/models/tests/unit/controllers/backends/deployments_plugin/test_resolve.py services/core/models/tests/unit/controllers/backends/deployments_plugin/test_compiler.py services/core/models/tests/unit/controllers/backends/deployments_plugin/test_backend.py services/core/models/tests/unit/controllers/backends/deployments_plugin/test_status.py -q- 53 passeduv run --frozen pytest plugins/nemo-deployments/tests/unit/backends/docker/test_executor_config.py plugins/nemo-deployments/tests/unit/backends/docker/test_backend_mocked.py -q- 66 passeduv run --frozen pytest packages/nmp_testing/tests/unit/test_e2e_docker_backend.py packages/nemo_platform_ext/tests/quickstart/test_container.py -q- 56 passeduv run --frozen pytest tests/smoke_gpu/test_customizer_tasks.py::test_sdk_alias_resources_importable -q- 1 passeduv run --frozen ty check plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/config.py plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py plugins/nemo-deployments/tests/unit/backends/docker/test_executor_config.py plugins/nemo-deployments/tests/unit/backends/docker/test_backend_mocked.py- passeduv run ruff check tests/smoke_gpu/test_customizer_tasks.py- passeduv run ruff check plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/config.py plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py plugins/nemo-deployments/tests/unit/backends/docker/test_executor_config.py plugins/nemo-deployments/tests/unit/backends/docker/test_backend_mocked.py packages/nmp_testing/src/nmp/testing/e2e/docker.py packages/nmp_testing/tests/unit/test_e2e_docker_backend.py packages/nemo_platform_ext/src/nemo_platform_ext/quickstart/container.py packages/nemo_platform_ext/tests/quickstart/test_container.py- passeduv run ruff format --check plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/config.py plugins/nemo-deployments/src/nemo_deployments_plugin/backends/docker/backend.py plugins/nemo-deployments/tests/unit/backends/docker/test_executor_config.py plugins/nemo-deployments/tests/unit/backends/docker/test_backend_mocked.py packages/nmp_testing/src/nmp/testing/e2e/docker.py packages/nmp_testing/tests/unit/test_e2e_docker_backend.py packages/nemo_platform_ext/src/nemo_platform_ext/quickstart/container.py packages/nemo_platform_ext/tests/quickstart/test_container.py- passedgit diff --check- passedflox -q activate -- uv run pre-commit run -a- passedTargeted Platform-Deploy validation:
98787062c91c371d1b73203089e36b7c5e666ddeusing NVIDIA-NeMo/Platform-Deploy#209 at44b7e20ee896ed4f2eebf62a0fafe52f93d3a277.