-
Notifications
You must be signed in to change notification settings - Fork 638
Fix Python formatting #3962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
klecki
merged 29 commits into
NVIDIA:main
from
klecki:python-formatting-with-yapf-and-autopep8
Jun 13, 2022
Merged
Fix Python formatting #3962
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
332d8ca
Fix Python formatting
klecki 02c90b9
autopep8
klecki 9947b14
More work for less changes
klecki 7822505
Next files
klecki 3256884
Selective format
klecki c49e097
Wasting developer's time
klecki 6f7365d
Doing by hand what should be done by a script
klecki 4801e39
Cleanup
klecki 7df1fb9
bricon
klecki 60ea32e
Dense packing
klecki c952ebc
Selectiv apply
klecki da934ec
Leave the code unformatted for less conveninece in the future
klecki 88ff42f
Asserts
klecki 942608b
Less in multipaste
klecki a42a4d8
Next files
klecki c96ac3f
Dense packing in debug
klecki dd20f5a
argh
klecki 242bfd7
sadasdas
klecki a15d920
Missing stuff
klecki 38d7352
Add missing import
klecki b0039d3
Apply suggestions from code review
klecki e99bec9
add some space around colon
klecki e1a6fa0
Revert "add some space around colon"
klecki 06daabf
Fixes
klecki f62d72b
Fixes
klecki 9392ad9
Latest fixes
klecki 649be9e
Less backslashes, more?
klecki d324b97
Adjustments
klecki cf9dd80
Fixes
klecki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this parenthesis required for anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To not use the
\
I'd say it's preferred.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP8 says so, I guess, but it still looks no less weird than a backslash (and perhaps more so).