Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sequence_parallel for mixtral peft train/eval #420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions launcher_scripts/conf/evaluation/peft_mixtral/squad.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ exp_manager:

model:
seed: 1234
tensor_model_parallel_size: 8
pipeline_model_parallel_size: 1
tensor_model_parallel_size: 1
pipeline_model_parallel_size: 8

global_batch_size: 32
micro_batch_size: 4
Expand All @@ -39,7 +39,7 @@ model:
sync_batch_comm: False
megatron_amp_02: False

sequence_parallel: True
sequence_parallel: False

activations_checkpoint_granularity: null
activations_checkpoint_method: null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ exp_manager:

model:
seed: 1234
tensor_model_parallel_size: 8
pipeline_model_parallel_size: 1
tensor_model_parallel_size: 1
pipeline_model_parallel_size: 8

global_batch_size: 32
micro_batch_size: 4
Expand All @@ -39,7 +39,7 @@ model:
sync_batch_comm: False
megatron_amp_02: False

sequence_parallel: True
sequence_parallel: False

activations_checkpoint_granularity: null
activations_checkpoint_method: null
Expand Down
6 changes: 3 additions & 3 deletions launcher_scripts/conf/peft/mixtral/squad.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ exp_manager:

model:
seed: 1234
tensor_model_parallel_size: 8 # intra-layer model parallelism
pipeline_model_parallel_size: 1 # inter-layer model parallelism
tensor_model_parallel_size: 1 # intra-layer model parallelism
pipeline_model_parallel_size: 8 # inter-layer model parallelism

tp_comm_overlap_disable_qkv: True
global_batch_size: 128
Expand All @@ -71,7 +71,7 @@ model:
## Sequence Parallelism
# Makes tensor parallelism more memory efficient for LLMs (20B+) by parallelizing layer norms and dropout sequentially
# See Reducing Activation Recomputation in Large Transformer Models: https://arxiv.org/abs/2205.05198 for more details.
sequence_parallel: True
sequence_parallel: False

## Activation Checkpoint
activations_checkpoint_granularity: null # 'selective' or 'full'
Expand Down
4 changes: 2 additions & 2 deletions launcher_scripts/conf/peft/mixtral/squad_8x22b.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ exp_manager:

model:
seed: 1234
tensor_model_parallel_size: 8 # intra-layer model parallelism
pipeline_model_parallel_size: 1 # inter-layer model parallelism
tensor_model_parallel_size: 1 # intra-layer model parallelism
pipeline_model_parallel_size: 8 # inter-layer model parallelism

tp_comm_overlap_disable_qkv: True
global_batch_size: 128
Expand Down
Loading