fix(logging): handle missing id and task in verbose logs #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes potential AttributeError exceptions in verbose logging by adding safe attribute access for id and task fields in log records. The changes ensure the logging system gracefully handles cases where these attributes may be missing.
Key Changes
- Replaces direct attribute access with
getattr()calls using default values - Provides fallback display formatting when
idis missing - Uses "unknown" as default for missing
taskattributes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Update verbose logging to safely handle cases where log records may not have 'id' or 'task' attributes. Prevents potential AttributeError and improves robustness of LLM and prompt log output formatting.
Pouyanpi
force-pushed
the
fix/logging-verbose
branch
from
74fb99c to
3018311
Compare
|
required by #1339 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1343 +/- ##
========================================
Coverage 70.70% 70.71%
========================================
Files 161 161
Lines 16312 16317 +5
========================================
+ Hits 11533 11538 +5
Misses 4779 4779
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cparisien
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update verbose logging to safely handle cases where log records may not have 'id' or 'task' attributes. Prevents potential
AttributeErrorand improves robustness of LLM and prompt log output formatting.