feat: add built-in Dynamo session lineage#348
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used📓 Path-based instructions (14)**/*📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{rs,py,go,ts,js,mjs,cjs,jsx,tsx,c,h}📄 CodeRabbit inference engine (AGENTS.md)
Files:
crates/node/**📄 CodeRabbit inference engine (AGENTS.md)
Files:
**⚙️ CodeRabbit configuration file
Files:
crates/{python,ffi,node}/**/*⚙️ CodeRabbit configuration file
Files:
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}⚙️ CodeRabbit configuration file
Files:
**/*.mdx📄 CodeRabbit inference engine (.agents/skills/review-doc-style/SKILL.md)
Files:
docs/**/*.{md,mdx}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*.{rs,go,js,ts,py,html,md,mdx,toml,yml,yaml,c,h}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*.{md,mdx}📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Files:
docs/**/*.mdx📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Files:
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}⚙️ CodeRabbit configuration file
Files:
**/*.rs📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
Files:
crates/**/*.{rs,py,ts,js,c,h}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (4)
WalkthroughTurn scopes now use Custom classification, observability routing and coverage expectations follow that turn role, and managed LLM requests receive Dynamo lineage headers derived from Agent scope ancestry. ChangesTurn scope and observability updates
Estimated code review effort: 3 (Moderate) | ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size:M
willkill07
changed the title
github-actions
Bot
added
Feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/core/src/api/shared.rs`:
- Around line 47-84: The parent session resolution in resolve_agent_session_ids
is skipping the nearest explicit Agent ancestor when two scopes resolve to the
same id. Update the logic so the parent is taken directly from the immediate
next Agent scope in the stack iteration, instead of using a search that can skip
duplicates; keep the identifier resolution behavior in agent_scope_id unchanged.
In `@crates/core/tests/unit/shared_tests.rs`:
- Around line 233-358: Add coverage for the codec-active branch in
run_request_intercepts_with_codec, since this test currently only exercises
codec: None. Introduce a case that passes a codec, then assert the Dynamo
lineage headers are still present after the encoded.headers = request.headers
path runs and that any existing codec-populated headers are preserved. Use the
existing test helpers and symbols like run_request_intercepts_with_codec,
DYNAMO_SESSION_ID_HEADER_KEY, and DYNAMO_PARENT_SESSION_ID_HEADER_KEY to keep
the new assertion near the current lifecycle checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 399c99fc-ef97-4f37-ba68-e69f684fbb01
📒 Files selected for processing (11)
crates/cli/src/alignment/mod.rscrates/cli/src/session.rscrates/cli/tests/coverage/server_tests.rscrates/cli/tests/coverage/session_tests.rscrates/core/src/api/llm.rscrates/core/src/api/shared.rscrates/core/src/observability/atif.rscrates/core/src/observability/plugin_component.rscrates/core/tests/unit/shared_tests.rscrates/node/tests/scope_local_tests.mjsdocs/instrument-applications/instrument-llm-call.mdx
📜 Review details
🧰 Additional context used
📓 Path-based instructions (31)
**/*.rs
📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Use
snake_casenaming convention for Rust identifiers (e.g.,nemo_relay_tool_call)
**/*.rs: Any Rust change must runjust test-rust
Any Rust change must runcargo fmt --all
Any Rust change must runcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allfor all FFI work since it is Rust work
Runjust test-rustto validate FFI changes
Runcargo clippy --workspace --all-targets -- -D warningsto enforce strict linting on FFI workWhen Rust files changed as part of Go work, also run
cargo fmt --all,just test-rust, andcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allwhen Rust files are changed as part of Node work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files are changed as part of Node work
Runjust test-rustwhen Rust files are changed as part of Node work
**/*.rs: Runcargo fmt --allto format all Rust code
Runcargo clippy --workspace --all-targets -- -D warningsto enforce all clippy lints as errors
**/*.rs: Runcargo fmt --allwhen Rust files changed as part of WebAssembly work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files changed as part of WebAssembly work
**/*.rs: If any Rust code changed, always runjust test-rust
If any Rust code changed, also runcargo fmt --all
If any Rust code changed, also runcargo clippy --workspace --all-targets -- -D warnings
Run Rust formatting withcargo fmt --all
Run Rust linting withcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Usecargo fmtfor Rust code formatting
Runcargo clippy -- -D warningsto lint Rust code and treat all warnings as errors
Use Rust snake_case naming convention for Rust identifiers
Include SPDX license header in all Rust source files using double-slash comment syntax
Validate Rust code withuv run pre-commit run --all-filesto enforce cargo fmt formatting check, cargo clippy lints, and cargo deny aud...
Files:
crates/cli/src/alignment/mod.rscrates/cli/src/session.rscrates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/cli/tests/coverage/server_tests.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rscrates/cli/tests/coverage/session_tests.rs
**/{Cargo.toml,**/*.rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Maintain consistency between Rust package names in
Cargo.tomland their actual usage across the codebase
Files:
crates/cli/src/alignment/mod.rscrates/cli/src/session.rscrates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/cli/tests/coverage/server_tests.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rscrates/cli/tests/coverage/session_tests.rs
**/*.{h,hpp,c,cpp,rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Ensure FFI header and library naming follows consistent conventions across platform-specific builds
Files:
crates/cli/src/alignment/mod.rscrates/cli/src/session.rscrates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/cli/tests/coverage/server_tests.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rscrates/cli/tests/coverage/session_tests.rs
**/*.{rs,toml}
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update Rust crate names and module prefixes during coordinated rename operations
Files:
crates/cli/src/alignment/mod.rscrates/cli/src/session.rscrates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/cli/tests/coverage/server_tests.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rscrates/cli/tests/coverage/session_tests.rs
**/*.{rs,py,js,ts,tsx,jsx,go,sh,toml,yaml,yml,md}
📄 CodeRabbit inference engine (AGENTS.md)
Keep SPDX headers on source, docs, scripts, and configuration files. The project is Apache-2.0.
Files:
crates/cli/src/alignment/mod.rscrates/cli/src/session.rscrates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/cli/tests/coverage/server_tests.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rscrates/cli/tests/coverage/session_tests.rs
**/*.{rs,py,go,js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Follow binding naming conventions: Rust and Python use
snake_case, C FFI exports prefixednemo_relay_, Go usesPascalCasefor public APIs, Node.js usescamelCase.
Files:
crates/cli/src/alignment/mod.rscrates/cli/src/session.rscrates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/cli/tests/coverage/server_tests.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rscrates/cli/tests/coverage/session_tests.rs
crates/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
crates/**/*.rs: Keep async behavior on the existing tokio-based model. Bindings should preserve callback and future lifetimes rather than blocking or hiding async work unexpectedly.
UseJson = serde_json::Valuein Rust-facing runtime APIs for JSON payload handling.
Files:
crates/cli/src/alignment/mod.rscrates/cli/src/session.rscrates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/cli/tests/coverage/server_tests.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rscrates/cli/tests/coverage/session_tests.rs
**
⚙️ CodeRabbit configuration file
**:AGENTS.md
This file provides guidance to agents, including Claude Code and OpenAI Codex, when working in this repository.
Project Overview
NeMo Relay is a multi-language agent runtime framework for execution scopes, lifecycle events, middleware, plugins, and observability around tool and LLM calls. The core runtime is Rust. Primary supported bindings are Rust, Python, and Node.js. Go and the raw C FFI are experimental and source-first.
The shared runtime model is:
- Scope stacks decide where work belongs and which scope-local behavior is visible.
- Middleware registries decide what guardrails and intercepts run around managed calls.
- Plugins install reusable runtime behavior from configuration.
- Events record runtime behavior in ATOF form.
- Subscribers and exporters consume events in-process or export them to ATIF, OpenTelemetry, OpenInference, or other backends.
Repository Structure
The repository layout separates the Rust runtime, language bindings,
documentation, integrations, and agent-facing skills.crates/ core/ # Rust core runtime crate, published as nemo-relay adaptive/ # Adaptive runtime primitives and plugin components python/ # PyO3 native extension for the Python package ffi/ # Raw C ABI layer used by downstream bindings such as Go node/ # NAPI Node.js binding and JavaScript/TypeScript entry points python/ nemo_relay/ # Python wrapper package: scopes, tools, LLM, middleware, typed helpers, plugins, adaptive helpers tests/ # Python tests go/ nemo_relay/ # Experimental Go CGo binding and tests fern/ # Fern documentation site scripts/ # Stable wrappers and helper scripts; build/test/docs entry points live in justfile skills/ # Published Codex/agent skills for NeMo Relay usage patternsPrerequisites
Insta...
Files:
crates/cli/src/alignment/mod.rsdocs/instrument-applications/instrument-llm-call.mdxcrates/cli/src/session.rscrates/node/tests/scope_local_tests.mjscrates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/cli/tests/coverage/server_tests.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rscrates/cli/tests/coverage/session_tests.rs
{docs/**,README.md,CONTRIBUTING.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
{docs/**,README.md,CONTRIBUTING.md}: For docs-only changes, run targeted checks only if commands, package names, or examples changed. Usejust docsfor docs-site builds andjust docs-linkcheckwhen links changed
Run docs site build withjust docs
Files:
docs/instrument-applications/instrument-llm-call.mdx
{docs/**,README.md,CONTRIBUTING.md,**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Run docs link validation with
just docs-linkcheckwhen links change
Files:
docs/instrument-applications/instrument-llm-call.mdx
{docs/**,README.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Verify README and docs entry points still match current package names and paths for large or public-facing changes
Files:
docs/instrument-applications/instrument-llm-call.mdx
{docs/**,examples/**,README.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Verify examples still run with documented commands for large or public-facing changes
Files:
docs/instrument-applications/instrument-llm-call.mdx
{docs/**,README.md,**/Cargo.toml,**/package.json,**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Ensure renamed public surfaces are reflected consistently in manifests and docs for large or public-facing changes
Files:
docs/instrument-applications/instrument-llm-call.mdx
**/*.{md,mdx,py,sh,yaml,yml,toml,json}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repo references, and build commands current
Files:
docs/instrument-applications/instrument-llm-call.mdx
**/*.mdx
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
In MDX files, top-of-file comments must use JSX comment delimiters: {/* to open and */} to close. Do not use HTML comments for MDX SPDX headers.
MDX top-of-file SPDX comments must use {/* ... */} delimiters instead of HTML comment delimiters (Must-Fix)
Files:
docs/instrument-applications/instrument-llm-call.mdx
**/*.{html,md,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license header in HTML and Markdown files using HTML comment syntax
Files:
docs/instrument-applications/instrument-llm-call.mdx
docs/**/*.{md,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update embedded documentation snippets, patch docs, and binding-support notes if examples or supported bindings changed
Files:
docs/instrument-applications/instrument-llm-call.mdx
docs/**
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run
just docsor./scripts/build-docs.sh htmlto regenerate ignored Fern API reference pages before validation for documentation site changes
Files:
docs/instrument-applications/instrument-llm-call.mdx
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}: Review documentation for technical accuracy against the current API, command correctness, and consistency across language bindings.
Flag stale examples, missing SPDX headers where required, and instructions that no longer match CI or pre-commit behavior.
Files:
docs/instrument-applications/instrument-llm-call.mdx
{crates/adaptive/**,python/nemo_relay/adaptive.py,python/nemo_relay/plugin.py,go/nemo_relay/adaptive/**,go/nemo_relay/!(adaptive)/**,**/node/**,**/wasm/**}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Keep adaptive surface in sync across crates/adaptive, shared plugin behavior in core and bindings, Python adaptive/plugin wrappers in python/nemo_relay/adaptive.py and python/nemo_relay/plugin.py, Go adaptive helpers under go/nemo_relay/adaptive plus shared plugin helpers in go/nemo_relay, and Node/WebAssembly adaptive helpers and plugin wrappers
Files:
crates/node/tests/scope_local_tests.mjs
{crates/adaptive/**,python/nemo_relay/plugin.py,go/nemo_relay/**,**/node/**,**/wasm/**}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
{crates/adaptive/**,python/nemo_relay/plugin.py,go/nemo_relay/**,**/node/**,**/wasm/**}: Maintain consistent plugin lifecycle across all language bindings (Python, Go, Node/WebAssembly, and Rust)
Keep plugin context surfaces aligned across all language implementations
Files:
crates/node/tests/scope_local_tests.mjs
crates/{python,ffi,node}/**/*
⚙️ CodeRabbit configuration file
crates/{python,ffi,node}/**/*: Treat binding changes as public API changes. Check for parity with the other language bindings, FFI ownership/lifetime safety,
callback error propagation, stable type conversion, and consistent async/stream semantics.
Flag changes that update one binding without corresponding tests or documentation for the same surface elsewhere.
Files:
crates/node/tests/scope_local_tests.mjs
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}
⚙️ CodeRabbit configuration file
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.
Files:
crates/node/tests/scope_local_tests.mjscrates/core/tests/unit/shared_tests.rscrates/cli/tests/coverage/server_tests.rscrates/cli/tests/coverage/session_tests.rs
{crates/adaptive/**/*.rs,**/*test*.{rs,py,go,ts,js},**/*adaptive*test*.{rs,py,go,ts,js},docs/plugins/adaptive/**}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Maintain documented and tested validation and report behavior for adaptive surfaces
Files:
crates/core/tests/unit/shared_tests.rscrates/cli/tests/coverage/server_tests.rscrates/cli/tests/coverage/session_tests.rs
{crates/core,crates/adaptive}/**/*
📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)
Changes to
crates/coreorcrates/adaptivemust run the full language matrix
Files:
crates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rs
crates/core/**/*.rs
📄 CodeRabbit inference engine (.agents/skills/test-go-binding/SKILL.md)
If the change touched
crates/coreor shared runtime semantics, also usevalidate-changefor broader validation
crates/core/**/*.rs: UseJson = serde_json::Valuein Rust-facing runtime APIs where the existing code expects JSON payloads.
UseResult<T>withFlowErrorin core runtime paths. Keep errors explicit and binding-appropriate at the wrapper layer.
Files:
crates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rs
crates/{core,adaptive}/**
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
If
crates/coreorcrates/adaptivechanged, run the full matrix across Rust, Python, Go, Node.js, and WebAssembly
Files:
crates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rs
crates/{core,adaptive}/**/*.rs
⚙️ CodeRabbit configuration file
crates/{core,adaptive}/**/*.rs: Review the Rust runtime for async correctness, scope isolation, middleware ordering, and event lifecycle regressions.
Pay close attention to task-local/thread-local scope propagation, callback lifetimes, stream finalization, and root_uuid isolation.
Public API changes should preserve existing behavior unless tests and docs show the intended migration path.
Files:
crates/core/tests/unit/shared_tests.rscrates/core/src/api/llm.rscrates/core/src/observability/plugin_component.rscrates/core/src/observability/atif.rscrates/core/src/api/shared.rs
crates/core/src/api/**/*.rs
📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Implement behavior first in Rust core API modules:
crates/core/src/api/and related core modules such ascrates/core/src/api/runtime/,crates/core/src/codec/, orcrates/core/src/json.rs
Files:
crates/core/src/api/llm.rscrates/core/src/api/shared.rs
crates/core/src/api/{tool,llm}.rs
📄 CodeRabbit inference engine (.agents/skills/add-middleware/SKILL.md)
Wire the new middleware chain into the execute path in
crates/core/src/api/tool.rsorcrates/core/src/api/llm.rsat the appropriate pipeline stage
Files:
crates/core/src/api/llm.rs
crates/core/src/observability/{atif,otel,openinference}.rs
📄 CodeRabbit inference engine (.agents/skills/maintain-observability/SKILL.md)
When changing event fields in ATIF, OpenTelemetry, or OpenInference observability surfaces, keep the core event model in
crates/core/src/observability/atif.rs,crates/core/src/observability/otel.rs, andcrates/core/src/observability/openinference.rsin sync
Files:
crates/core/src/observability/atif.rs
🔇 Additional comments (11)
crates/cli/src/alignment/mod.rs (1)
612-614: LGTM!crates/cli/src/session.rs (1)
1164-1194: LGTM!crates/core/src/observability/plugin_component.rs (1)
15-18: LGTM!Also applies to: 1315-1336
crates/cli/tests/coverage/server_tests.rs (1)
654-666: LGTM!Also applies to: 1521-1522
crates/cli/tests/coverage/session_tests.rs (1)
723-756: LGTM!Also applies to: 1819-1834, 1916-1921, 2966-2975, 2994-3011, 3109-3118, 3138-3156
crates/core/src/observability/atif.rs (1)
3124-3127: 🎯 Functional CorrectnessNo issue: this helper is a pure extraction of the existing
ScopeType::Agentcheck, and custom turns already follow the fallback path handled by the existing Codex/Hermes ATIF flow.> Likely an incorrect or invalid review comment.crates/core/src/api/shared.rs (2)
13-24: LGTM!
175-185: 🗄️ Data Integrity & IntegrationNo issue here:
LlmCodec::encodeimplementations currently cloneoriginal.headersand do not add codec-specific headers, so this assignment does not discard codec output.> Likely an incorrect or invalid review comment.crates/core/src/api/llm.rs (1)
23-24: LGTM!Also applies to: 906-927
crates/node/tests/scope_local_tests.mjs (1)
270-270: LGTM!docs/instrument-applications/instrument-llm-call.mdx (1)
35-42: LGTM!
Signed-off-by: Will Killian <wkillian@nvidia.com>
mnajafian-nv
left a comment
mnajafian-nv
left a comment
There was a problem hiding this comment.
LGTM overall. I left two small inline polish notes around public-contract wording and local comment consistency. Please also clear the remaining Rust Runtime coverage gate before merge.
Signed-off-by: Will Killian <wkillian@nvidia.com>
lvojtku
left a comment
lvojtku
left a comment
There was a problem hiding this comment.
Edits to use active voice. Approved with comments
Co-authored-by: lvojtku <lvojtku@nvidia.com> Signed-off-by: Will Killian <2007799+willkill07@users.noreply.github.com>
|
/merge |
3 participants
Overview
Implements RELAY-404 by making Dynamo session lineage propagation built into managed LLM requests and representing every CLI turn as a
Customscope.Details
x-dynamo-session-idandx-dynamo-parent-session-idautomatically from the active Agent scope stack.Customscope while preserving Agent-only lineage and classification.Validation:
just test-rustcompleted all runtime suites but encountered the repository's parallel FFI shared-global race; the full 75-test FFI suite passes serially. Also rancargo clippy --workspace --all-targets -- -D warnings,just test-node,just test-go,just docs, focused Python tests (93 passed), and pre-commit checks.Where should the reviewer start?
Start with
crates/core/src/api/shared.rsfor Agent-only Dynamo lineage injection, thencrates/cli/src/session.rsfor the universal Custom turn scope. The ATIF top-level Custom-turn routing is incrates/core/src/observability/plugin_component.rs.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit