Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malay/bw scripts #11961

Merged
merged 40 commits into from
Feb 10, 2025
Merged

Malay/bw scripts #11961

merged 40 commits into from
Feb 10, 2025

Conversation

malay-nagda
Copy link
Collaborator

@malay-nagda malay-nagda commented Jan 26, 2025

What does this PR do ?

Adds Blackwell (B200) performance configs.
Adds supports to pick performance optimized configs from a csv file.

Collection: [llm]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

python3 scripts/llm/performance/pretrain_llama3_8b.py -a coreai_dlalgo_llm -p batch -i nvcr.io/nvidia/nemo:24.12 -g b200

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

malay-nagda and others added 11 commits January 26, 2025 21:03
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 3, 2025

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module utils
scripts/llm/performance/utils.py:132:0: C0115: Missing class docstring (missing-class-docstring)
scripts/llm/performance/utils.py:144:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/llm/performance/utils.py:173:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.97/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

malay-nagda and others added 2 commits February 6, 2025 00:34
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
erhoo82
erhoo82 previously approved these changes Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.43%. Comparing base (09186c3) to head (8b7d848).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11961      +/-   ##
==========================================
+ Coverage   30.30%   30.43%   +0.12%     
==========================================
  Files        1387     1400      +13     
  Lines      176283   177498    +1215     
  Branches    27091    27203     +112     
==========================================
+ Hits        53423    54017     +594     
- Misses     118776   119357     +581     
- Partials     4084     4124      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

[🤖]: Hi @malay-nagda 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Signed-off-by: Malay Nagda <[email protected]>
Copy link
Contributor

@guyueh1 guyueh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Feb 7, 2025

[🤖]: Hi @malay-nagda 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

malay-nagda and others added 6 commits February 10, 2025 13:50
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Copy link
Contributor

[🤖]: Hi @malay-nagda 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@erhoo82 erhoo82 merged commit 3242c9e into main Feb 10, 2025
233 checks passed
@erhoo82 erhoo82 deleted the malay/bw_scripts branch February 10, 2025 20:51
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* bw perf scripts

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* lora mcomm overlap

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* debug

Signed-off-by: Malay Nagda <[email protected]>

* recommended configs per gpu

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* pre-defined perf configs

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* minor

Signed-off-by: Malay Nagda <[email protected]>

* minor

Signed-off-by: Malay Nagda <[email protected]>

* cleanup

Signed-off-by: Malay Nagda <[email protected]>

* conflicting arg names

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* b200 support

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* CG, TB, ETP

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* TB

Signed-off-by: Malay Nagda <[email protected]>

* b200 perf scripts

Signed-off-by: Malay Nagda <[email protected]>

* b200 perf scripts

Signed-off-by: Malay Nagda <[email protected]>

* CG, UB

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* CG, UB

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* ub typo fix

Signed-off-by: Malay Nagda <[email protected]>

* 2x22b num gpus

Signed-off-by: Malay Nagda <[email protected]>

* csv fix

Signed-off-by: Malay Nagda <[email protected]>

* etp support

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* 70b no CG

Signed-off-by: Malay Nagda <[email protected]>

* bw perf scripts

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* bw perf scripts

Signed-off-by: Malay Nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Feb 20, 2025
* bw perf scripts

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* lora mcomm overlap

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* debug

Signed-off-by: Malay Nagda <[email protected]>

* recommended configs per gpu

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* pre-defined perf configs

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* minor

Signed-off-by: Malay Nagda <[email protected]>

* minor

Signed-off-by: Malay Nagda <[email protected]>

* cleanup

Signed-off-by: Malay Nagda <[email protected]>

* conflicting arg names

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* b200 support

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* CG, TB, ETP

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* TB

Signed-off-by: Malay Nagda <[email protected]>

* b200 perf scripts

Signed-off-by: Malay Nagda <[email protected]>

* b200 perf scripts

Signed-off-by: Malay Nagda <[email protected]>

* CG, UB

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* CG, UB

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* ub typo fix

Signed-off-by: Malay Nagda <[email protected]>

* 2x22b num gpus

Signed-off-by: Malay Nagda <[email protected]>

* csv fix

Signed-off-by: Malay Nagda <[email protected]>

* etp support

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* 70b no CG

Signed-off-by: Malay Nagda <[email protected]>

* bw perf scripts

Signed-off-by: Malay Nagda <[email protected]>

* Apply isort and black reformatting

Signed-off-by: malay-nagda <[email protected]>

* bw perf scripts

Signed-off-by: Malay Nagda <[email protected]>

---------

Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Co-authored-by: malay-nagda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants