[MoE] fix run err in mixtral22B recipe and update its perf config #12036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gdeng <[email protected]>
Signed-off-by: gdeng <[email protected]>
gdengk
force-pushed
the
gaod/moe/update_mixtral22b_perf_config
branch
from
8c5896f to
016e20e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12036 +/- ##
=======================================
Coverage 30.30% 30.30%
=======================================
Files 1387 1387
Lines 176283 176283
Branches 27091 27091
=======================================
+ Hits 53423 53427 +4
+ Misses 118776 118772 -4
Partials 4084 4084 ☔ View full report in Codecov by Sentry. |
|
@ko3n1g @pablo-garay can we force-merge this one? it's config change. |
ko3n1g
approved these changes
Feb 4, 2025
BoxiangW
pushed a commit
that referenced
this pull request
Feb 7, 2025
…2036) * update mixtral-22B performance config Signed-off-by: gdeng <[email protected]> * fix run err in mixtral22B recipe Signed-off-by: gdeng <[email protected]> * Apply isort and black reformatting Signed-off-by: gdengk <[email protected]> --------- Signed-off-by: gdeng <[email protected]> Signed-off-by: gdengk <[email protected]> Co-authored-by: gdengk <[email protected]>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
…IDIA#12036) * update mixtral-22B performance config Signed-off-by: gdeng <[email protected]> * fix run err in mixtral22B recipe Signed-off-by: gdeng <[email protected]> * Apply isort and black reformatting Signed-off-by: gdengk <[email protected]> --------- Signed-off-by: gdeng <[email protected]> Signed-off-by: gdengk <[email protected]> Co-authored-by: gdengk <[email protected]> Signed-off-by: Youngeun Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information