interface for asymmetric pipeline schedule #12039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @erhoo82 , could you update the file |
Signed-off-by: Sangkug Lym <[email protected]>
Signed-off-by: erhoo82 <[email protected]>
|
Please address linting |
jiemingz
previously approved these changes
Feb 11, 2025
Signed-off-by: Sangkug Lym <[email protected]>
Signed-off-by: erhoo82 <[email protected]>
jiemingz
approved these changes
Feb 12, 2025
8 tasks
tomlifu
pushed a commit
to tomlifu/NeMo
that referenced
this pull request
Feb 20, 2025
* interface for asymmetric pipeline schedule Signed-off-by: Sangkug Lym <[email protected]> * Apply isort and black reformatting Signed-off-by: erhoo82 <[email protected]> * linting fix Signed-off-by: Sangkug Lym <[email protected]> * Apply isort and black reformatting Signed-off-by: erhoo82 <[email protected]> --------- Signed-off-by: Sangkug Lym <[email protected]> Signed-off-by: erhoo82 <[email protected]> Co-authored-by: erhoo82 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add the interface for the asymmetric pipeline schedule
Changelog
account_for_embedding_in_pipeline_splitandaccount_for_loss_in_pipeline_splitargs that consider input embedding and loss functions when splitting layers for pipeline schedule.Usage
Set
account_for_embedding_in_pipeline_split=Trueandaccount_for_loss_in_pipeline_split=TrueGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information