Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num nodes to match parallel mappings #12170

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

erhoo82
Copy link
Collaborator

@erhoo82 erhoo82 commented Feb 13, 2025

What does this PR do ?

Fix the number of nodes in a recipe; the previous number of nodes was not divisible by model-parallel sizes

Changelog

  • Use 64 nodes instead of 74 nodes in LLAMA3.1 405B recipe

Usage

n/a

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@malay-nagda malay-nagda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the NLP label Feb 13, 2025
@erhoo82 erhoo82 added Run CICD and removed Run CICD labels Feb 13, 2025
@erhoo82 erhoo82 enabled auto-merge (squash) February 13, 2025 19:58
@erhoo82 erhoo82 merged commit d608621 into NVIDIA:main Feb 14, 2025
223 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants