Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf script fix #12285

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Perf script fix #12285

merged 3 commits into from
Feb 25, 2025

Conversation

guyueh1
Copy link
Contributor

@guyueh1 guyueh1 commented Feb 20, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

This PR fixes typo in scripts/performance/llm/README and add two new benchmarks to the gb200 recommended configs.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@malay-nagda malay-nagda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@erhoo82 erhoo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyueh1
Copy link
Contributor Author

guyueh1 commented Feb 20, 2025

@erhoo82 need to trigger CICD? Though I think it isn't nececessary, no code under nemo/ is changed.

@guyueh1
Copy link
Contributor Author

guyueh1 commented Feb 21, 2025

@erhoo82 what's next step for this? Need CI? thx.

@guyueh1
Copy link
Contributor Author

guyueh1 commented Feb 24, 2025

@erhoo82 pls start CI for this, thx

@pablo-garay pablo-garay enabled auto-merge (squash) February 24, 2025 21:59
@pablo-garay
Copy link
Collaborator

@erhoo82 pls start CI for this, thx

started

@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Feb 24, 2025
@ko3n1g ko3n1g disabled auto-merge February 25, 2025 09:48
@ko3n1g ko3n1g enabled auto-merge (squash) February 25, 2025 09:49
@ko3n1g ko3n1g disabled auto-merge February 25, 2025 09:49
@ko3n1g ko3n1g enabled auto-merge (squash) February 25, 2025 09:49
@ko3n1g ko3n1g merged commit 8a8466c into NVIDIA:main Feb 25, 2025
244 of 963 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants