Skip to content

additional metrics #13754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

additional metrics #13754

wants to merge 18 commits into from

Conversation

dimapihtar
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

dimapihtar and others added 3 commits May 28, 2025 05:36
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>

import time
from collections import deque
from typing import Any, Optional, Union

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'Optional' is not used.
Import of 'Union' is not used.

Copilot Autofix

AI 3 days ago

To fix the issue, we will remove the unused Optional import from the typing module. This will clean up the code and eliminate the unnecessary dependency. The change will be made on line 17 of the file nemo/lightning/pytorch/callbacks/speed_monitor.py.


Suggested changeset 1
nemo/lightning/pytorch/callbacks/speed_monitor.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/nemo/lightning/pytorch/callbacks/speed_monitor.py b/nemo/lightning/pytorch/callbacks/speed_monitor.py
--- a/nemo/lightning/pytorch/callbacks/speed_monitor.py
+++ b/nemo/lightning/pytorch/callbacks/speed_monitor.py
@@ -16,3 +16,3 @@
 from collections import deque
-from typing import Any, Optional, Union
+from typing import Any, Union
 
EOF
@@ -16,3 +16,3 @@
from collections import deque
from typing import Any, Optional, Union
from typing import Any, Union

Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
from typing import Any, Optional, Union

import lightning.pytorch as pl
import torch

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'torch' is not used.

Copilot Autofix

AI 3 days ago

To fix the issue, the unused import statement for torch on line 20 should be removed. This will eliminate the unnecessary dependency and improve code clarity. No other changes are required, as the removal of the import does not affect the functionality of the code.


Suggested changeset 1
nemo/lightning/pytorch/callbacks/speed_monitor.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/nemo/lightning/pytorch/callbacks/speed_monitor.py b/nemo/lightning/pytorch/callbacks/speed_monitor.py
--- a/nemo/lightning/pytorch/callbacks/speed_monitor.py
+++ b/nemo/lightning/pytorch/callbacks/speed_monitor.py
@@ -19,3 +19,3 @@
 import lightning.pytorch as pl
-import torch
+
 import torch.distributed as dist
EOF
@@ -19,3 +19,3 @@
import lightning.pytorch as pl
import torch

import torch.distributed as dist
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
import torch
import torch.distributed as dist

from nemo.utils import logging

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'logging' is not used.

Copilot Autofix

AI 3 days ago

To fix the issue, the unused import statement from nemo.utils import logging on line 23 should be removed. This will eliminate the unnecessary dependency and improve code readability without affecting functionality.

Suggested changeset 1
nemo/lightning/pytorch/callbacks/speed_monitor.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/nemo/lightning/pytorch/callbacks/speed_monitor.py b/nemo/lightning/pytorch/callbacks/speed_monitor.py
--- a/nemo/lightning/pytorch/callbacks/speed_monitor.py
+++ b/nemo/lightning/pytorch/callbacks/speed_monitor.py
@@ -22,3 +22,3 @@
 
-from nemo.utils import logging
+
 
EOF
@@ -22,3 +22,3 @@

from nemo.utils import logging


Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant