-
Notifications
You must be signed in to change notification settings - Fork 2.9k
additional metrics #13754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
additional metrics #13754
Conversation
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
… into dpykhtar/wandb_metrics
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
Signed-off-by: dimapihtar <[email protected]>
… into dpykhtar/wandb_metrics
|
||
import time | ||
from collections import deque | ||
from typing import Any, Optional, Union |
Check notice
Code scanning / CodeQL
Unused import Note
Import of 'Union' is not used.
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix the issue, we will remove the unused Optional
import from the typing
module. This will clean up the code and eliminate the unnecessary dependency. The change will be made on line 17 of the file nemo/lightning/pytorch/callbacks/speed_monitor.py
.
-
Copy modified line R17
@@ -16,3 +16,3 @@ | ||
from collections import deque | ||
from typing import Any, Optional, Union | ||
from typing import Any, Union | ||
|
from typing import Any, Optional, Union | ||
|
||
import lightning.pytorch as pl | ||
import torch |
Check notice
Code scanning / CodeQL
Unused import Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix the issue, the unused import statement for torch
on line 20 should be removed. This will eliminate the unnecessary dependency and improve code clarity. No other changes are required, as the removal of the import does not affect the functionality of the code.
-
Copy modified line R20
@@ -19,3 +19,3 @@ | ||
import lightning.pytorch as pl | ||
import torch | ||
|
||
import torch.distributed as dist |
import torch | ||
import torch.distributed as dist | ||
|
||
from nemo.utils import logging |
Check notice
Code scanning / CodeQL
Unused import Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 days ago
To fix the issue, the unused import statement from nemo.utils import logging
on line 23 should be removed. This will eliminate the unnecessary dependency and improve code readability without affecting functionality.
-
Copy modified line R23
@@ -22,3 +22,3 @@ | ||
|
||
from nemo.utils import logging | ||
|
||
|
Important
The
Update branch
button must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information