test(cli): stabilize coverage dist sourcemaps

[cv]

Summary

Stabilize CLI coverage runs by cleaning compiled CLI output before coverage builds and validating that generated JavaScript sourcemaps point at existing sources. This makes coverage use a clean dist/ baseline instead of stale generated files.

Stack Navigation

• Position: 46 of 60
• Previous PR: #2944 — test(cli): cover runtime utility helpers
• Next PR: #2962 — refactor(cli): extract maintenance image helpers

Changes

• Added npm run clean:cli for removing stale dist/ artifacts without changing the normal build:cli ordering.
• Added scripts/check-dist-sourcemaps.ts and npm run dist:sourcemaps:check to fail fast on stale generated sourcemaps.
• Updated the CLI coverage pre-push hook to clean dist/, rebuild, and validate sourcemaps before running coverage.
• Rebaselined CLI function coverage to the clean-dist value exposed by the stabilized run.
• Added unit coverage for the sourcemap checker.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela [email protected]

Summary by CodeRabbit

• Chores

  • Enhanced pre-commit checks with additional build and cleanup steps before testing
  • Added validation for sourcemap integrity in the distribution directory
  • Adjusted code coverage thresholds for CLI functions

• Tests

  • Added tests for sourcemap validation

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3b05c242-58fe-4252-90e8-5611b51d5548

📥 Commits

Reviewing files that changed from the base of the PR and between 8741a50 and 26c85d7.

📒 Files selected for processing (5)

• .pre-commit-config.yaml
• ci/coverage-threshold-cli.json
• package.json
• scripts/check-dist-sourcemaps.ts
• test/dist-sourcemaps.test.ts

---

📝 Walkthrough

Walkthrough

A new source map validation feature is introduced that scans the dist directory for .js.map files, verifies that all referenced sources exist, and integrates into the pre-commit test pipeline via npm scripts and configuration updates.

Changes

Source Map Validation Feature

Layer / File(s)	Summary
Core Implementation scripts/check-dist-sourcemaps.ts	New TypeScript script that defines source map types, directory traversal logic, and a public function findMissingDistSourcemapSources(distDir: string): string[] to scan .js.map files and verify referenced sources exist. Treats internal sources as relative to map file and external sources (node:, webpack://, node_modules, absolute paths) as valid.
NPM Script Integration package.json	Two scripts added: clean:cli to recursively remove dist directory, and dist:sourcemaps:check to invoke the check script via tsx.
Pre-commit Hook Integration .pre-commit-config.yaml	Updated test-cli hook to run npm run clean:cli && npm run build:cli && npm run dist:sourcemaps:check before Vitest, ensuring builds are clean and sourcemaps are validated prior to test execution.
Tests & Coverage Config test/dist-sourcemaps.test.ts, ci/coverage-threshold-cli.json	New test file validates findMissingDistSourcemapSources against temporary sourcemap structures with present and missing sources. Coverage threshold for "functions" adjusted from 32 to 31.8 to accommodate new code.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 A rabbit hops through dist with care,
Checking maps for sources fair,
Builds now clean before tests run,
Sourcemaps verified—our work is done! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/stabilize-cli-coverage-dist

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[prekshivyas]

LGTM. Test infrastructure / build hygiene PR — 5 files / +120 / -2, no src/ touched.

• clean:cli + dist:sourcemaps:check npm scripts added.
• New scripts/check-dist-sourcemaps.ts walks .js.map files and asserts every sources entry resolves on disk; correctly skips node:/webpack:///node_modules/absolute paths.
• Pre-commit test-cli hook now runs clean:cli && build:cli && dist:sourcemaps:check before vitest coverage — defensive against stale dist/ polluting coverage.
• Coverage function threshold rebaselined 32 → 31.8 to reflect the real value once stale dist files (which had been counting deleted code as "covered") are eliminated. Rationale clearly explained in the PR description.
• +35 lines of fixture-based test for the sourcemap checker.

CI: pr.yaml mostly green (lint/dco/check-hash/legacy-path-guard/changes PASS); macos-e2e/wsl-e2e/checks + pr-self-hosted builds still in flight at review time. No failures.