refactor(cli): extract sandbox destroy helpers

[cv]

Summary

Extract pure sandbox destroy decision helpers from the destructive destroy action module.

Stack Navigation

• Position: 49 of 60
• Previous PR: #2963 — refactor(cli): extract upgrade sandbox helpers
• Next PR: #2965 — refactor(cli): extract sandbox logs helpers

Changes

• Added sandbox-destroy-helpers.ts for delete outcome parsing and cleanup decision helpers.
• Updated destroy and rebuild actions to import delete outcome parsing from the helper module.
• Moved/added helper tests for missing-sandbox output, delete outcomes, host-service cleanup decisions, and gateway cleanup decisions.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• Refactor

  • Reorganized sandbox deletion utilities and result interpretation into a new shared helpers module.
  • Decoupled gateway cleanup and host services shutdown decision logic from primary deletion operations.

• Tests

  • Added comprehensive test coverage for new sandbox destruction helper utilities.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e4fe44d8-d8e8-4701-bf0f-175b5808ec20

📥 Commits

Reviewing files that changed from the base of the PR and between b34e5fd and 3c29e55.

📒 Files selected for processing (5)

• src/lib/sandbox-destroy-action.ts
• src/lib/sandbox-destroy-helpers.test.ts
• src/lib/sandbox-destroy-helpers.ts
• src/lib/sandbox-rebuild-action.ts
• test/image-cleanup.test.ts

---

📝 Walkthrough

Walkthrough

This PR extracts sandbox destruction decision logic from sandbox-destroy-action.ts into a new sandbox-destroy-helpers.ts module, introducing reusable utility functions for interpreting deletion outcomes and determining when to clean up gateway and host services. Comprehensive tests are added for the new helpers, and dependent imports are updated accordingly.

Changes

Sandbox Destroy Logic Refactoring

Layer / File(s)	Summary
New Helper Module src/lib/sandbox-destroy-helpers.ts	Introduces SpawnLikeResult type, isMissingSandboxDeleteOutput(), getSandboxDeleteOutcome(), shouldStopHostServicesAfterDestroy(), and shouldCleanupGatewayAfterDestroy() to centralize delete-outcome interpretation and cleanup decision logic.
Test Coverage src/lib/sandbox-destroy-helpers.test.ts	Comprehensive Vitest suite validating detection of missing sandbox outputs (including ANSI-colored variants), delete-outcome classification, and boolean decision logic for host services and gateway cleanup across multiple scenarios.
Main Action Refactoring src/lib/sandbox-destroy-action.ts	Removes in-file SpawnLikeResult type and getSandboxDeleteOutcome() implementation; imports these from sandbox-destroy-helpers; replaces inline gateway-cleanup and host-services-shutdown logic with calls to shouldCleanupGatewayAfterDestroy() and shouldStopHostServicesAfterDestroy().
Import Updates src/lib/sandbox-rebuild-action.ts, test/image-cleanup.test.ts	Updates imports to fetch getSandboxDeleteOutcome from sandbox-destroy-helpers instead of sandbox-destroy-action; removeSandboxRegistryEntry and removeSandboxImage remain imported from sandbox-destroy-action.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 A rabbit's refactoring delight,
Decision logic, clean and tight,
Helpers extracted, tested true,
Modular code through and through!
No more rabbitholes—just clarity bright. ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/retry-sandbox-destroy-helpers

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[prekshivyas]

LGTM. Same pattern as #2962/#2963 — pure helper extraction. 5 files / +147 / -34.

Four helpers in new sandbox-destroy-helpers.ts:

• isMissingSandboxDeleteOutput (renamed from ...Result for clarity).
• getSandboxDeleteOutcome (moved out of sandbox-destroy-action.ts).
• shouldStopHostServicesAfterDestroy — wraps the inline "only sandbox + still registered" gate.
• shouldCleanupGatewayAfterDestroy — wraps the four-clause final-gateway-cleanup gate.

Inline boolean blobs become named helper calls with structured input objects — strictly more readable, behavior identical. Import paths in sandbox-rebuild-action.ts and test/image-cleanup.test.ts migrated to the new module — no zombie imports.

+70 lines of direct unit tests covering ANSI stripping, three delete-outcome cases, and both decision helpers. Existing test count not reduced (1 line touched in image-cleanup.test.ts is just the import path).

CI: pr.yaml mostly green (lint/dco/check-hash/legacy-path-guard/macos-e2e/changes PASS); wsl-e2e/checks + pr-self-hosted builds still in flight at review time. No failures.