refactor(cli): group oclif core modules

[cv]

Summary

Start the CLI layer directory structure by grouping oclif core/runtime modules under src/lib/cli/. This makes argv normalization, dispatch, oclif runtime helpers, metadata lookup, public help rendering, and the shared command base visibly part of the CLI boundary.

Stack Navigation

• Position: 52 of 60
• Previous PR: #2966 — refactor(cli): extract policy channel helpers
• Next PR: #2970 — refactor(cli): split oclif commands by command tree

Changes

• Moved oclif core modules and their tests into src/lib/cli/.
• Updated imports from src/nemoclaw.ts, root help, and existing command adapters.
• Kept command behavior unchanged; this PR is a file-structure/import move only.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela [email protected]

Summary by CodeRabbit

• Refactor
  • Reorganized internal CLI module structure by moving related components into a dedicated subdirectory for improved code organization and maintainability. Updated import paths across multiple files to reflect the new hierarchy. Enhanced command metadata resolution to support additional packaging layouts. No changes to user-facing functionality or CLI behavior.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 03b6854b-8bcf-4d99-9579-7f6d43a2f03d

📥 Commits

Reviewing files that changed from the base of the PR and between 89427ba and 15a4664.

📒 Files selected for processing (18)

• src/lib/cli/argv-normalizer.test.ts
• src/lib/cli/argv-normalizer.ts
• src/lib/cli/nemoclaw-oclif-command.ts
• src/lib/cli/oclif-dispatch.test.ts
• src/lib/cli/oclif-dispatch.ts
• src/lib/cli/oclif-metadata.test.ts
• src/lib/cli/oclif-metadata.ts
• src/lib/cli/oclif-runner.test.ts
• src/lib/cli/oclif-runner.ts
• src/lib/cli/public-oclif-help.test.ts
• src/lib/cli/public-oclif-help.ts
• src/lib/destroy-cli-command.ts
• src/lib/list-command.ts
• src/lib/maintenance-cli-commands.ts
• src/lib/rebuild-cli-command.ts
• src/lib/root-help-action.ts
• src/lib/status-command.ts
• src/nemoclaw.ts

---

📝 Walkthrough

Walkthrough

This PR reorganizes CLI-related modules by consolidating imports under a lib/cli/ namespace and updating import paths across the codebase. Additionally, module resolution for Oclif command metadata is expanded to support multiple packaging layouts.

Changes

CLI Module Reorganization

Layer / File(s)	Summary
Runtime Module Resolution src/lib/cli/oclif-metadata.ts	Search path candidates for oclif command metadata expanded from two locations to three: ../oclif-commands, ../oclif-commands.js, and ../../../dist/lib/oclif-commands.js to support additional packaging layouts.
CLI Submodule Imports src/lib/cli/argv-normalizer.test.ts, src/lib/cli/oclif-runner.ts, src/lib/cli/public-oclif-help.ts	Import paths updated within the cli directory: test imports adjusted to ./argv-normalizer; oclif-runner.ts and public-oclif-help.ts imports for CLI_NAME changed from ./branding to ../branding.
Parent Lib Imports src/lib/destroy-cli-command.ts, src/lib/list-command.ts, src/lib/maintenance-cli-commands.ts, src/lib/rebuild-cli-command.ts, src/lib/status-command.ts	Import paths for NemoClawCommand updated from ./nemoclaw-oclif-command to ./cli/nemoclaw-oclif-command across five command files.
Helper Module Imports src/lib/root-help-action.ts	Import path for getRegisteredOclifCommandSummary changed from ./oclif-metadata to ./cli/oclif-metadata.
Entry Point src/nemoclaw.ts	Main entry point updated with reorganized imports: oclif-runner from ./lib/oclif-runner to ./lib/cli/oclif-runner; cli-related modules consolidated under lib/cli/ namespace (argv-normalizer, public-oclif-help, oclif-dispatch).

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hoppy hop, files rearranged,
CLI modules neatly exchanged,
Paths adjusted left and right,
Namespace tidy, structure tight!
Metadata searches far and wide,
Organization as our guide. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly and concisely summarizes the main change: grouping oclif core modules into src/lib/cli/. All file changes involve moving or updating imports for CLI modules into the cli subdirectory.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/layer-cli-core-modules

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[prekshivyas]

LGTM. Pure file-organization PR — 18 files / +18 / -14, with all renames tracked by git at 97–100% similarity.

Six oclif-core modules move src/lib/<name>.ts → src/lib/cli/<name>.ts. The only substantive content change is in oclif-metadata.ts: dynamic-require fallback paths shift to account for the new subdir location, plus a new ../oclif-commands.js entry to handle compiled-dist packaging layouts. Consumer files (6 + nemoclaw.ts) have one-line import-path updates.

Public CLI surface unchanged. Test files renamed alongside their sources.

CI: fully green across every check — pr.yaml (lint/dco/check-hash/legacy-path-guard/macos-e2e/changes/checks/test-e2e-ollama-proxy) + pr-self-hosted (build-sandbox-images/arm64, test-e2e-sandbox/gateway-isolation/port-overrides) + CodeRabbit. Cleanest hash on the stack.