Conversation
This reverts commit 4ebeae4.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request reorganizes module structure by consolidating CLI action exports into a single public API surface at ChangesModule Import Path Consolidation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
## Summary Move sandbox-scoped workflow action modules into `src/lib/actions/sandbox/**` so command adapters and sandbox workflow orchestration have separate, visible layers. ## Stack Navigation - Position: 57 of 60 - Previous PR: [#2986 — test(cli): enforce initial layer import boundaries](#2986) - Next PR: [#2988 — refactor(cli): group global actions](#2988) ## Changes - Moved sandbox connect/destroy/rebuild/status/logs/doctor/gateway-state/process-recovery/skill/snapshot actions under `src/lib/actions/sandbox/`. - Moved sandbox policy/channel action helpers under `src/lib/actions/sandbox/policy-channel.ts`. - Updated command adapters, runtime dispatch facade, tests, and remaining callers to the new paths. - Kept behavior unchanged; this PR is a structural move plus import updates. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files --stage pre-push` passes - [x] `npm run build:cli` - [x] `npm run typecheck:cli` - [x] `npx tsx scripts/check-layer-import-boundaries.ts` - [x] Sandbox command adapter targeted tests pass - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the style guide (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <[email protected]> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Enhanced sandbox cleanup during destruction to properly unload Ollama models, terminate proxy processes, and stop host services for complete resource cleanup. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <[email protected]>
Signed-off-by: Carlos Villela <[email protected]>
prekshivyas
left a comment
There was a problem hiding this comment.
LGTM. Same #2984/#2985-pattern PR — pure file-organization, 26 files / +64 / -64.
Six action modules (deploy, global + test, maintenance, onboard, root-help, upgrade-sandboxes) moved under src/lib/actions/. The +N/-N on moved files reflects their internal imports shifting. 19 consumer files (commands, nemoclaw.ts, tests) have one-line import-path updates.
Verification checklist explicitly cites running check-layer-import-boundaries.ts from #2986 — strong signal nothing escapes the new layer rules.
CI: pr.yaml mostly green (lint/dco/check-hash/legacy-path-guard/changes PASS); CodeRabbit SUCCESS; macos-e2e/wsl-e2e/checks + pr-self-hosted builds still in flight at review time. No failures.
## Summary Move registry, config, path, gateway, session, and sandbox persistence modules into `src/lib/state/**` so persistence boundaries are visible in paths. ## Stack Navigation - Position: 59 of 60 - Previous PR: [#2988 — refactor(cli): group global actions](#2988) - Next PR: [#2991 — refactor(cli): group docker adapters](#2991) ## Changes - Moved registry/config/path/gateway/session/sandbox state modules under `src/lib/state/`. - Moved co-located state tests and updated dist/source paths in integration tests. - Updated action, command, onboarding, policy, service, and test imports to the new state paths. - Updated CodeRabbit path instructions and migrated-path guard canonical paths for moved state modules. - Kept behavior unchanged; this PR is a structural move plus import updates. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] `npx prek run --all-files --stage pre-push` passes - [x] `npm run build:cli` - [x] `npm run typecheck:cli` - [x] `npx tsx scripts/check-layer-import-boundaries.ts` - [x] State and registry targeted tests pass - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `make docs` builds without warnings (doc changes only) - [ ] Doc pages follow the style guide (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <[email protected]> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Reorganized internal state management modules into a dedicated directory structure to improve code organization and maintainability. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <[email protected]>
Summary
Move top-level/global workflow action modules into
src/lib/actions/**so command adapters call a visible action layer instead of flatsrc/libmodules.Stack Navigation
Changes
src/lib/actions/.Type of Change
Verification
npx prek run --all-files --stage pre-pushpassesnpm run build:clinpm run typecheck:clinpx tsx scripts/check-layer-import-boundaries.tsmake docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela [email protected]
Summary by CodeRabbit