Skip to content

docs(policy): add reserved PRR label taxonomy#5369

Merged
cv merged 2 commits into
mainfrom
codex/add-prr-label-policy
Jun 12, 2026
Merged

docs(policy): add reserved PRR label taxonomy#5369
cv merged 2 commits into
mainfrom
codex/add-prr-label-policy

Conversation

@wscurran

@wscurran wscurran commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds PRR as a canonical Product Readiness Review label for reports and follow-up used to assess product readiness and user experience. Marks the label as reserved so normal triage agents never recommend or apply it.

Changes

  • Add PRR to the human-readable shared maintainer label taxonomy as a reserved reporting label.
  • Add PRR to the machine-readable taxonomy with triage_recommendation_allowed: false.
  • Update shared maintainer-policy triage instructions to forbid recommending PRR during triage.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Will Curran wcurran@nvidia.com

Verification notes:

  • jq validation passed for .agents/skills/nemoclaw-maintainer-policies/references/label-taxonomy.json.
  • git diff --check passed.
  • npm run docs passed outside the sandbox with 0 errors and 2 Fern warnings.
  • npx prek run --all-files is blocked locally because hadolint is not installed.

Summary by CodeRabbit

  • Documentation

    • Updated label taxonomy documentation with comprehensive guidance and definitions for reporting-related scenarios and use cases.
    • Enhanced triage instructions with explicit clarifications regarding label handling, restriction guidelines, and best practices for consistent application across workflows.
  • Chores

    • Added new canonical label definition to the label taxonomy configuration system.

Signed-off-by: Will Curran <wcurran@nvidia.com>
@wscurran wscurran added chore Build, CI, dependency, or tooling maintenance area: skills Skills, agent behaviors, prompts, or skill packaging area: project-management Taxonomy, triage, workflow, roadmap, or project process labels Jun 12, 2026
@wscurran wscurran self-assigned this Jun 12, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 562dec32-99b5-4f88-ae84-e4d724ce0655

📥 Commits

Reviewing files that changed from the base of the PR and between 6949f55 and b2ac0ae.

📒 Files selected for processing (3)
  • .agents/skills/nemoclaw-maintainer-policies/references/label-taxonomy.json
  • .agents/skills/nemoclaw-maintainer-policies/references/label-taxonomy.md
  • .agents/skills/nemoclaw-maintainer-policies/references/triage-instructions.md

📝 Walkthrough

Walkthrough

A new PRR (Product Readiness Review) label is introduced to the maintainer policies taxonomy with schema definitions, documentation guidance, and triage enforcement rules preventing automated agent recommendations.

Changes

PRR Label Introduction

Layer / File(s) Summary
PRR label taxonomy definition and documentation
.agents/skills/nemoclaw-maintainer-policies/references/label-taxonomy.json, label-taxonomy.md
The PRR label is defined in the canonical label schema with family set to reporting, applicable to issue and pull request items, with triage_recommendation_allowed: false. Documentation adds PRR use guidance to the label taxonomy and introduces a new "Reporting" section with positive/negative signal criteria and usage constraints.
Triage enforcement rules for PRR
triage-instructions.md
Core Rules and Anti-Examples sections are updated to explicitly prohibit triage agents from recommending the reserved PRR label, clarifying that it is restricted to maintainers or dedicated workflows.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A label named PRR hops into view,
Where maintainers alone review and renew,
No triage may touch it, the rules are quite clear—
A product-ready badge, exclusively dear! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a new reserved PRR label to the taxonomy documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/add-prr-label-policy

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. No E2E is recommended because this PR only updates maintainer/agent policy reference documentation and taxonomy data for triage labeling. It cannot affect NemoClaw runtime behavior, installer/onboarding, sandbox lifecycle, credentials, security enforcement, network policy, inference routing, deployment, or real assistant user flows.

Optional E2E

  • None.

New E2E recommendations

  • None.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: None
Optional Vitest E2E scenarios: None

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required Vitest E2E scenarios

  • None. Changed files are maintainer policy/triage documentation under .agents and do not affect the Vitest E2E scenario registry, workflow, runtime support, live tests, fixtures, manifests, or scenario behavior.

Optional Vitest E2E scenarios

  • None.

Relevant changed files

  • None.

@wscurran wscurran requested a review from cv June 12, 2026 22:34
@wscurran wscurran marked this pull request as ready for review June 12, 2026 22:34
@wscurran wscurran enabled auto-merge (squash) June 12, 2026 22:35
@github-actions

Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 0 worth checking, 0 nice ideas

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@cv cv disabled auto-merge June 12, 2026 22:48
@cv cv merged commit a326eba into main Jun 12, 2026
33 checks passed
@cv cv deleted the codex/add-prr-label-policy branch June 12, 2026 22:48
@cv cv added the v0.0.65 Release target label Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: project-management Taxonomy, triage, workflow, roadmap, or project process area: skills Skills, agent behaviors, prompts, or skill packaging chore Build, CI, dependency, or tooling maintenance v0.0.65 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants