ci(e2e): derive free-standing selectors from workflow#5370
Merged
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughFree-standing Vitest inventory is derived from workflow job YAML markers; a new TypeScript CLI exports it as shell key=value or JSON; the workflow’s matrix generator invokes and strictly validates that output; jobs are tagged with env markers; boundary validators and tests were updated to use the derived inventory. ChangesFree-standing inventory migration
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Contributor
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tools/e2e-scenarios/workflow-boundary.mts`:
- Around line 1910-1912: The inventory-derived jobs returned by
deriveFreeStandingJobsInventoryFromJobs are only passed to
validateFreeStandingInventoryCoverage and therefore skip boundary checks (needs,
shared selector if, pinned actions, secret placement) enforced by
validateE2eVitestScenariosWorkflowBoundary; update the flow so that
freeStandingInventory (from deriveFreeStandingJobsInventoryFromJobs) is also
passed through validateFreeStandingJobSelector and any existing lane-specific
validators used for explicit free-standing jobs (e.g. the secret-bearing lanes)
— add calls to validateFreeStandingJobSelector(freeStandingInventory, ...) and
route secret-bearing inventory entries to the dedicated validators used by
validateE2eVitestScenariosWorkflowBoundary so those checks (needs, if selectors,
pinned actions, secret placement) run on derived-inventory jobs as well.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fc4022c5-12aa-46ea-af25-3a96426397b1
📒 Files selected for processing (5)
.github/workflows/e2e-vitest-scenarios.yamltest/e2e-scenario/support-tests/e2e-scenarios-workflow.test.tstools/e2e-scenarios/free-standing-jobs.envtools/e2e-scenarios/free-standing-workflow-inventory.mtstools/e2e-scenarios/workflow-boundary.mts
💤 Files with no reviewable changes (1)
- tools/e2e-scenarios/free-standing-jobs.env
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27449811792
|
Contributor
Vitest E2E Scenario Results — ❌ Some jobs failedRun: 27450569888
|
Contributor
Vitest E2E Scenario Results — ✅ All jobs passedRun: 27450569888
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Derives free-standing E2E Vitest job and scenario selectors from metadata in
.github/workflows/e2e-vitest-scenarios.yamlinstead of the shared env-file registry. This removes the append-only selector file as a merge-conflict point while keeping CI selector validation strict.Related Issue
Refs #5098
Changes
FREE_STANDING_VITEST_JOBandFREE_STANDING_SCENARIO_IDmetadata to free-standing E2E jobs.tools/e2e-scenarios/free-standing-workflow-inventory.mtsto emit shell-safe selector inventory from workflow YAML.tools/e2e-scenarios/free-standing-jobs.env.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Chores
Tests