Skip to content

ci(e2e): route token rotation through compatible endpoint#5374

Merged
cv merged 1 commit into
mainfrom
codex/token-rotation-compatible-endpoint
Jun 13, 2026
Merged

ci(e2e): route token rotation through compatible endpoint#5374
cv merged 1 commit into
mainfrom
codex/token-rotation-compatible-endpoint

Conversation

@cv

@cv cv commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

Route the legacy token-rotation nightly E2E through the CI-compatible inference setup so it can use the NVIDIA_INFERENCE_API_KEY secret with https://inference-api.nvidia.com/v1. This keeps public documentation and provider text unchanged while aligning this CI path with the endpoint that now works for nightly coverage.

Changes

  • Set NEMOCLAW_E2E_USE_NVIDIA_SECRET_AS_COMPATIBLE=1 on the token-rotation-e2e nightly job.
  • Source and invoke test/e2e/lib/ci-compatible-inference.sh from test/e2e/test-token-rotation.sh.
  • Add workflow contract coverage to keep the token-rotation job wired to the compatible inference helper.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

Release Notes

  • Tests

    • Added verification test for nightly token rotation workflow configuration and CI environment setup.
  • Chores

    • Updated end-to-end token rotation test to properly configure inference credentials for CI environments.

@cv cv self-assigned this Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cfa2dfa0-a711-4d2e-a703-c2ed62db8591

📥 Commits

Reviewing files that changed from the base of the PR and between ef8e43b and ef884e9.

📒 Files selected for processing (3)
  • .github/workflows/nightly-e2e.yaml
  • test/e2e-script-workflow.test.ts
  • test/e2e/test-token-rotation.sh

📝 Walkthrough

Walkthrough

The token rotation E2E test is integrated with CI-compatible inference by adding configuration sourcing to the test script, setting a corresponding workflow environment variable, and verifying the integration through a contract test.

Changes

Token Rotation E2E CI-Compatible Inference Routing

Layer / File(s) Summary
Token rotation test script with CI-compatible inference
test/e2e/test-token-rotation.sh
The test script sources test/e2e/lib/ci-compatible-inference.sh and calls nemoclaw_e2e_configure_compatible_inference before test phases run. Documentation for NVIDIA_INFERENCE_API_KEY is updated to reflect the CI-compatible inference requirement.
Workflow environment setup and test verification
.github/workflows/nightly-e2e.yaml, test/e2e-script-workflow.test.ts
The token-rotation-e2e job environment sets NEMOCLAW_E2E_USE_NVIDIA_SECRET_AS_COMPATIBLE: "1". A new contract test verifies the job step environment includes this variable and the test script sources the CI-compatible inference helper and calls the configuration function.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

area: ci, area: e2e, area: inference, nightly-e2e

Suggested reviewers

  • jyaunches
  • prekshivyas

Poem

🐰 Tokens spin through Compatible Skies 🌙

With compatible inference now in place,
E2E tests run with compatible grace!
Helper sourced, env set, verified true—
Token rotation flows as intended to do. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ci(e2e): route token rotation through compatible endpoint' accurately captures the main change: routing the token rotation E2E test through a CI-compatible inference endpoint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/token-rotation-compatible-endpoint

Comment @coderabbitai help to get the list of available commands and usage tips.

@cv cv added the v0.0.65 Release target label Jun 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 1 worth checking, 0 nice ideas
Top item: PR review advisor unavailable

Review findings

🛠️ Needs attention

  • None.

🔎 Worth checking

  • PR review advisor unavailable: The automated advisor could not complete: Could not parse JSON from PR review advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/pr-review-advisor/pr-review-advisor-raw-output.txt
    • Recommendation: Re-run the PR Review Advisor or perform a manual review.
    • Evidence: Could not parse JSON from PR review advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/pr-review-advisor/pr-review-advisor-raw-output.txt

🌱 Nice ideas

  • None.
Consider writing more tests for
  • **Runtime validation** — Add or identify targeted runtime/integration validation for the changed behavior; do not report external E2E job pass/fail here.. Runtime/sandbox/infrastructure paths need behavioral runtime validation: .github/workflows/nightly-e2e.yaml.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Failed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-advisor-raw-output.txt

@github-actions

Copy link
Copy Markdown
Contributor

Vitest E2E Scenario Recommendation

Required Vitest E2E scenarios: None
Optional Vitest E2E scenarios: None

Workflow run

Full Vitest E2E advisor summary

Vitest E2E Scenario Advisor

Failed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-scenario-advisor-raw-output.txt

@cv cv merged commit 9610f37 into main Jun 13, 2026
44 checks passed
@cv cv deleted the codex/token-rotation-compatible-endpoint branch June 13, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v0.0.65 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant