ci(e2e): route token rotation through compatible endpoint#5374
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe token rotation E2E test is integrated with CI-compatible inference by adding configuration sourcing to the test script, setting a corresponding workflow environment variable, and verifying the integration through a contract test. ChangesToken Rotation E2E CI-Compatible Inference Routing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
This is an automated advisory review. A human maintainer must make the final merge decision. |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-advisor-raw-output.txt |
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-scenario-advisor-raw-output.txt |
Summary
Route the legacy token-rotation nightly E2E through the CI-compatible inference setup so it can use the
NVIDIA_INFERENCE_API_KEYsecret withhttps://inference-api.nvidia.com/v1. This keeps public documentation and provider text unchanged while aligning this CI path with the endpoint that now works for nightly coverage.Changes
NEMOCLAW_E2E_USE_NVIDIA_SECRET_AS_COMPATIBLE=1on thetoken-rotation-e2enightly job.test/e2e/lib/ci-compatible-inference.shfromtest/e2e/test-token-rotation.sh.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Release Notes
Tests
Chores