fix(e2e): replace brittle source-string assertion in skill CLI test#5376
Draft
hunglp6d wants to merge 1 commit into
Draft
fix(e2e): replace brittle source-string assertion in skill CLI test#5376hunglp6d wants to merge 1 commit into
hunglp6d wants to merge 1 commit into
Conversation
OpenClaw >= 2026.5.27 classifies all installed skills as "openclaw-bundled" regardless of install origin, so the hard-coded `grep -Fq "openclaw-workspace"` assertion always fails. Replace the raw grep with a structured Python JSON check that confirms the fixture skill is present in the list output by name. The workspace install path is already validated on disk in Phase 4, so source-field classification is no longer a gate. Signed-off-by: Hung Le <hple@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
✨ [AI-generated PR]
The openclaw-skill-cli-e2e nightly job fails because OpenClaw >= 2026.5.27 classifies all installed skills as openclaw-bundled regardless of install origin. The test's hard-coded grep -Fq openclaw-workspace assertion always fails.
This PR replaces the raw grep with a structured Python JSON check that confirms the fixture skill is present in the list output by name. The workspace install path is already validated on disk in Phase 4, so source-field classification is no longer a correctness gate.
Root Cause
OpenClaw's skills list --json output changed its source field taxonomy. Previously workspace-installed skills reported source: openclaw-workspace; now they report source: openclaw-bundled. The E2E test was coupled to the old string value.
Changes
Nightly Run
Test Plan
Signed-off-by: Hung Le hple@nvidia.com
Fixes #5378