ci(coverage): upload reports to GitHub Code Quality#5383
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughCI workflows now generate Cobertura coverage XML for CLI and plugin tests and upload those reports; job-level permissions for ChangesCobertura Coverage Generation and Upload
Workflow Job Permission Hardening
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-advisor-raw-output.txt |
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorFailed: Could not parse JSON from advisor output; see /home/runner/work/NemoClaw/NemoClaw/artifacts/e2e-advisor/e2e-scenario-advisor-raw-output.txt |
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
This is an automated advisory review. A human maintainer must make the final merge decision. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/actions/ci-cli-coverage-merge/action.yaml:
- Around line 95-102: Update the conditional for the coverage upload steps so
they run even if earlier steps fail by adding always() while preserving the
existing fork-PR guard: in .github/actions/ci-cli-coverage-merge/action.yaml
(lines 95-102) replace the current if condition with one that wraps the existing
guard in always(), for example if: ${{ always() && (github.event_name !=
'pull_request' || github.event.pull_request.head.repo.full_name ==
github.repository) }}; do the same change in
.github/actions/ci-plugin-coverage/action.yaml (lines 35-42) — both sites
require the identical modification to the if condition so uploads run on failing
runs but still skip forked PRs.
In @.github/workflows/main.yaml:
- Around line 82-86: Remove the invalid "code-quality: write" permission entries
and replace them with the correct GitHub Actions permission required by
actions/upload-code-coverage (consult the action's README to determine whether
it needs actions: write, contents: write, or another valid scope) —
specifically: in .github/workflows/main.yaml (lines 82-86) remove code-quality:
write from the cli-tests job and add the validated permission scope; in
.github/workflows/main.yaml (lines 110-113) remove code-quality: write from the
plugin-tests job and add the validated permission scope; in
.github/workflows/pr.yaml (lines 236-240) remove code-quality: write from the
cli-tests job and add the validated permission scope; and in
.github/workflows/pr.yaml (lines 281-284) remove code-quality: write from the
plugin-tests job and add the validated permission scope.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 13c9d5d3-4e08-4a30-87be-3ec3b69a2b31
📒 Files selected for processing (4)
.github/actions/ci-cli-coverage-merge/action.yaml.github/actions/ci-plugin-coverage/action.yaml.github/workflows/main.yaml.github/workflows/pr.yaml
1 participant
Summary
Adds Cobertura XML generation to the existing CLI and plugin coverage jobs, then uploads those reports to GitHub Code Quality so coverage results can appear on pull requests. The upload steps reuse the existing coverage pipeline and keep fork PR uploads skipped.
Changes
actions/upload-code-coverage@v1and distinct labels.code-quality: writepermission required by GitHub Code Quality.docs/changes are needed for this CI-only reporting change.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit