perf(e2e): parallelize plugin EXDEV coverage - #7243
Conversation
…y-hang' into codex/diagnose-agent-turn-latency-hang
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit e8f07c9 in the TypeScript / code-coverage/cliThe overall coverage in commit e8f07c9 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — InformationalAdvisor assessment: Informational / medium confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
|
/nvskills-ci |
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
|
Superseded by #7449. The replacement preserves the EXDEV lane improvements on current main with one signed, GitHub-verified commit. Repository branch protection prevented rewriting this PR’s stale pre-squash history, so keeping both open would duplicate the same work. |
<!-- markdownlint-disable MD041 --> ## Summary Runs the exact v0.0.71 OpenClaw plugin baseline and the current restart/recreate/rebuild EXDEV lifecycle in independent jobs, reducing the critical path without dropping regression assertions. This clean current-`main` branch supersedes draft #7243 because repository rules disallow rewriting its stale, pre-squash history. ## Related Issue Part of #7140. Supersedes #7243. ## Changes - Split the combined live test into independently selectable release-baseline and current-lifecycle cases. - Add independent scheduled and regression-workflow jobs with distinct sandbox names, target IDs, artifact roots, and bounded timeouts. - Preserve the historical builder digest for the release fixture while rewriting the cloned fixture to the current reviewed builder digest for current-lifecycle validation. - Preserve the existing `openclaw-plugin-runtime-exdev` target for current lifecycle coverage and the existing regression dispatch selector. - Extend workflow boundary tests to protect both jobs, selectors, credential revocation, immutable action pins, artifact uploads, and result reporting. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [ ] Docs updated for user-facing behavior changes - [x] Docs not applicable — justification: This restructures internal E2E coverage; plugin behavior, public commands, and the external regression selector are unchanged. Existing fixture security and plugin-install documentation remains accurate. - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Workflow boundary tests require secret-free runtime steps, immediate Docker credential revocation, immutable action pins, read-only permissions, independent sandbox/artifact identities, and reviewed artifact upload actions for both lanes. - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Documentation Writer Review - [x] Documentation writer subagent reviewed the completed changes - Result: `no-docs-needed` - Evidence: Existing `docs/security/e2e-weather-plugin-fixture-dependency-review.md`, `docs/deployment/install-openclaw-plugins.mdx`, and `test/e2e/README.md` remain behaviorally accurate; this revision changes only internal E2E lane scheduling, selector wiring, workflow contracts, and test-fixture cleanup. - Agent: Codex documentation writer subagent <!-- docs-review-head-sha: 52abe0c --> <!-- docs-review-agents-blob-sha: 9c9b36d --> ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: Not applicable - Station profile/scenario: Not applicable - Result: Not applicable - Supporting evidence: Not applicable ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — The current-head EXDEV workflow boundary passed 2 tests, the regression workflow boundary passed 5 tests, semantic validation passed 124 tests across 82 files, and CLI build/typecheck plus the pre-push gate passed. - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: Targeted workflow, semantic, type, and push gates passed; GitHub CI is authoritative for the repository-wide gate. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Apurv Kumaria <akumaria@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Expanded end-to-end and regression coverage for OpenClaw custom-plugin EXDEV scenarios across **release-baseline** and **current-lifecycle** runs. * Strengthened runtime assertions for pinned plugin loading, restart/recreate/rebuild, and cross-device dependency replacement. * Updated secret-free workflow boundary checks, including multi-job contract validation and the revised runtime proof budget. * **Chores** * Added a scheduled **release-baseline** E2E run with release-pinned fixtures, dedicated artifacts, Docker auth handling/cleanup, and PR reporting integration. * Reduced EXDEV job timeouts and narrowed execution using explicit lifecycle selectors for faster feedback. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Apurv Kumaria <akumaria@nvidia.com> Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> Co-authored-by: Prekshi Vyas <prekshiv@nvidia.com>
Summary
Runs the exact v0.0.71 OpenClaw plugin baseline and the current restart/recreate/rebuild EXDEV lifecycle in independent jobs. The original sequential job took about 24m45s; parallel execution is expected to reduce the wall-clock critical path to roughly 17 minutes without dropping regression assertions.
Related Issue
Part of #7140.
Changes
openclaw-plugin-runtime-exdevtarget for current lifecycle coverage and the existing regression dispatch selector.Type of Change
Quality Gates
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm run test:projects:check, CLI type-check, Biome, YAML validation, and live-test collection passed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Charan Jagwani cjagwani@nvidia.com