fix(policy): register shared network schema at runtime#7531
Conversation
Signed-off-by: Ho Lim <subhoya@gmail.com>
📝 WalkthroughWalkthroughThe sandbox policy validator now loads and registers the network policy schema alongside the sandbox policy schema. The npm package whitelist and package contract test are updated to include and verify the published network schema. ChangesNetwork policy schema support
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Review Advisor — InformationalAdvisor assessment: Informational / high confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. Since last review: 0 prior items resolved · 0 still apply · 0 new items found E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
PR comparison verdict — #6877 runtime follow-upAcceptance criteria
Scorecard
All three patches have the same three-file behavior shape. In #7531:
Verdict: neither candidate is mergeable yet — select #7531#7531 wins the deterministic tie because it is the earliest equivalent PR and is authored by Ho Lim, the original #6877 contributor. Duplicate #7533 is closed. #7531 now has the required template, exact-head documentation receipt ( Next gate: exact-head CI/E2E must finish successfully and an independent approval must be recorded before merge. |
apurvvkumaria
left a comment
There was a problem hiding this comment.
Approved at exact head d133ec1. The selected original-author patch registers the shared network schema before sandbox-schema compilation, ships the referenced schema, and proves the packed installed package contains and exercises both schemas. Focused package-contract and policy suites pass; automated review reports no actionable findings.
Summary
Restore runtime sandbox-policy validation after #6877 extracted network policy definitions into an external schema. The runtime validator now registers that shared schema before compiling the sandbox schema, and the published package ships both files.
Changes
network-policy.schema.jsonbefore compiling the sandbox policy schema.Type of Change
Quality Gates
Documentation Writer Review
no-docs-neededWRITING.mdanddocs/CONTRIBUTING.md. The fix restores existing policy validation and package contents without changing the schema, configuration, supported behavior, or user workflow.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: Not applicable to this focused three-file integration repair.npm run docsbuilds without warnings (doc changes only)Follow-up to #6877. Supersedes duplicate #7533 and preserves Ho Lim's original-author credit.
Signed-off-by: Ho Lim subhoya@gmail.com
Summary by CodeRabbit
Bug Fixes
Chores