test(e2e): cover stale receipt page cap

[apurvvkumaria]

Summary

Add the exact upper-bound regression requested during review of #7595. A complete stale-receipt inventory containing 1,000 workflow runs across all 10 allowed pages must remain retryable rather than failing from an off-by-one pagination error.

Related Issue

Follow-up to #7595 and #7594 for #7593.
Part of #7140.

Changes

• Exercise the inclusive 1,000-run filtered-search cap.
• Require the receipt recheck to consume exactly 10 complete pages.
• Preserve the existing zero-correlation success contract at the boundary.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: this is a test-only boundary follow-up with no runtime or user-facing behavior change.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: Exact product-scope and nine-category security review PASS at 871b933840300068aef3f462a8ecf1d0873209dc (tree 4e2d18d2833a353776d6936fd22d28f3c95ad2d9, base 17a8ad1a6979de0b92b25eb93453dbbdf03cf61a). The diff is test-only; it exercises the exact fail-closed pagination boundary and changes no production code, dependency, permission, credential path, or supported product surface.
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: Test-only regression coverage for the existing GitHub filtered-result pagination cap; no user-visible behavior changed and fix(e2e): reconcile uncertain workflow dispatches #7594's operational guidance remains accurate.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — exact head 871b933840300068aef3f462a8ecf1d0873209dc: npx vitest run --project integration test/pr-e2e-dispatch-reconciliation.test.ts passed 35/35.
• Applicable broad gate passed — CLI build and exact-head npm run check:diff passed after generating the required dist/ artifacts.
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Apurv Kumaria akumaria@nvidia.com

Summary by CodeRabbit

• Tests
  • Added end-to-end coverage for reconciling complete stale receipt inventories at GitHub’s filtered-result limit.
  • Verified reconciliation succeeds with clock skew and across paginated inventory reads, including the page-cap boundary (ensuring calls span the expected pages).

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds an E2E test for complete stale receipt inventories at GitHub’s filtered-result cap. It simulates 1,000 unrelated workflow runs, verifies reconciliation succeeds beyond the time window, and checks pagination across pages 1–10.

Changes

Dispatch reconciliation validation

Layer / File(s)	Summary
Cap-boundary reconciliation test test/pr-e2e-dispatch-reconciliation.test.ts	Verifies assertDispatchStillNotObserved resolves with a complete stale inventory and performs 10 paginated inventory reads for pages 1 through 10.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• NVIDIA/NemoClaw#7594: Extends the dispatch reconciliation flow exercised by this test.
• NVIDIA/NemoClaw#7595: Implements the paginated stale-inventory behavior validated by this test.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the new E2E test coverage for the stale receipt pagination cap.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/7593-stale-receipt-cap-test

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 871b933 in the codex/7593-stale-rec... branch remains at 96%, unchanged from commit 17a8ad1 in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 871b933 in the codex/7593-stale-rec... branch remains at 80%, unchanged from commit 17a8ad1 in the main branch.

Show a code coverage summary of the most impacted files.

File	main 17a8ad1	codex/7593-stale-rec... 871b933	+/-
src/lib/onboard/docker-cdi.ts	80%	70%	-10%
src/lib/domain/.../connect-env.ts	97%	89%	-8%
src/lib/shields/index.ts	71%	67%	-4%
src/lib/onboard...host-anchors.ts	94%	90%	-4%
src/lib/onboard/preflight.ts	80%	80%	0%
src/lib/actions...light-guards.ts	86%	90%	+4%
src/lib/onboard...box-gpu-mode.ts	92%	97%	+5%
src/lib/actions...confirmation.ts	69%	79%	+10%
src/lib/actions...ocker-health.ts	65%	82%	+17%
src/lib/onboard...box-prebuild.ts	73%	92%	+19%

---

_{Updated July 26, 2026 21:45 UTC}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/pr-e2e-dispatch-reconciliation.test.ts`:
- Line 442: Update the pagination test around the existing api mock assertion to
capture api.mock.calls and verify the requested page query parameters are
exactly pages 1 through 10 in order, replacing the call-count-only assertion
while preserving the existing test setup.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e58bb3d2-2135-4fc5-984a-e8e6928bc298

📥 Commits

Reviewing files that changed from the base of the PR and between 2c30e11 and 17d04bb.

📒 Files selected for processing (1)

• test/pr-e2e-dispatch-reconciliation.test.ts

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized E2E selections match; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

[cv]

Approved at exact head 871b933. Product scope and nine-category security review pass; focused 35/35 and check:diff pass; all 51 current checks, both advisor lanes, CodeRabbit, exact docs receipt, and canonical merge gate pass with no unresolved review threads.