Skip to content

fix(ci): clear managed image platform pulls - #7953

Closed
prekshivyas wants to merge 1 commit into
mainfrom
codex/fix-managed-image-platform-pulls
Closed

fix(ci): clear managed image platform pulls#7953
prekshivyas wants to merge 1 commit into
mainfrom
codex/fix-managed-image-platform-pulls

Conversation

@prekshivyas

@prekshivyas prekshivyas commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Managed image publication now removes the local digest reference after each anonymous platform pull. This prevents Docker's classic image store from rejecting the next platform pull with cannot overwrite digest while preserving both architecture checks.

Changes

  • Remove each locally pulled digest reference before the next platform pull.
  • Make the managed-image promotion harness reproduce the same-digest platform collision.
  • Verify the cleanup order for every agent and supported architecture.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: This change repairs internal GitHub Actions image publication and does not change a user API, CLI, configuration, default, or supported workflow.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: The nine-category security review passed with no findings. The change removes only runner-local digest references; registry aliases, credentials, permissions, and authorization are unchanged.
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: no-docs-needed
  • Evidence: The change affects internal GitHub Actions image publication only. The reviewer found no user documentation requirement or blocking writing findings. The focused Linux integration test passed 12/12 after the final wording change.
  • Agent: Codex Desktop

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: Linux npx vitest run --project integration test/managed-image-publication-workflow.test.ts passed 12/12 in node:22-bookworm with jq.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Prekshi Vyas prekshiv@nvidia.com

Summary by CodeRabbit

  • Bug Fixes

    • Improved multi-platform image promotion by removing temporary image references before processing the next platform.
    • Prevented conflicting platform variants from being retained in the local Docker image store.
  • Tests

    • Added coverage confirming correct cleanup order and successful promotion.
    • Added validation for expected failure handling when image references are not removed.

@prekshivyas prekshivyas self-assigned this Jul 31, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 70d19208-fd67-433b-97d0-4b33f4939f38

📥 Commits

Reviewing files that changed from the base of the PR and between 4f74ea7 and f4ae478.

📒 Files selected for processing (3)
  • .github/workflows/managed-images.yaml
  • test/helpers/managed-image-publication-barrier.ts
  • test/managed-image-publication-workflow.test.ts

📝 Walkthrough

Walkthrough

The managed-image promotion workflow now removes anonymously pulled platform digest references before proceeding. Test infrastructure tracks Docker pulls and validates cleanup ordering, successful promotion, and the expected repeated-pull failure.

Changes

Managed image promotion cleanup

Layer / File(s) Summary
Remove pulled digest references
.github/workflows/managed-images.yaml
The workflow removes each staged cohort reference from the local Docker image store after pulling it.
Track and validate Docker references
test/helpers/managed-image-publication-barrier.ts, test/managed-image-publication-workflow.test.ts
The fake Docker executable tracks pulls and deletions, while tests verify per-platform cleanup order and collision failure behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • NVIDIA/NemoClaw#7756: Introduced the managed-image promotion workflow and its test harness.
  • NVIDIA/NemoClaw#7951: Modifies the same workflow and promotion tests for platform-specific Docker reference cleanup.

Suggested labels: area: ci, platform: container, bug-fix

Suggested reviewers: cv, jyaunches

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the CI fix that clears locally pulled managed-image platform references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-managed-image-platform-pulls

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit f4ae478 in the codex/fix-managed-im... branch remains at 96%, unchanged from commit 4f74ea7 in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit f4ae478 in the codex/fix-managed-im... branch remains at 81%, unchanged from commit 4f74ea7 in the main branch.

Show a code coverage summary of the most impacted files.
File main 4f74ea7 codex/fix-managed-im... f4ae478 +/-
src/lib/onboard...flight-ports.ts 67% 33% -34%
src/lib/onboard...box-prebuild.ts 92% 74% -18%
src/lib/actions...ocker-health.ts 82% 65% -17%
src/lib/actions...confirmation.ts 79% 69% -10%
src/lib/onboard...box-gpu-mode.ts 97% 92% -5%
src/lib/actions...orchestrator.ts 87% 83% -4%
src/lib/onboard/preflight.ts 80% 80% 0%
src/lib/onboard...host-anchors.ts 90% 94% +4%
src/lib/domain/.../connect-env.ts 89% 97% +8%
src/lib/onboard/docker-cdi.ts 70% 80% +10%

Updated July 31, 2026 00:19 UTC

@prekshivyas

Copy link
Copy Markdown
Collaborator Author

Security review

Verdict

PASS. This change removes a validated digest reference from the GitHub Actions runner-local Docker image store after each anonymous platform pull. It does not change registry aliases, credentials, permissions, or authorization. The PR has no security findings.

Findings

No findings.

Detailed analysis

  1. Secrets and Credentials — PASS: No credential material changes. Anonymous pulls still use the credential-free Docker configuration.
  2. Input Validation and Data Sanitization — PASS: The quoted digest reference comes from the validated six-candidate set.
  3. Authentication and Authorization — PASS: Workflow permissions and GitHub authentication are unchanged.
  4. Dependencies and Third-Party Libraries — PASS: The PR adds no dependency.
  5. Error Handling and Logging — PASS: The regression fixture preserves Docker's literal error and includes no sensitive value.
  6. Cryptography and Data Protection — PASS: The PR changes no cryptographic or protected-data behavior.
  7. Configuration and Security Headers — PASS: The command removes only a runner-local image reference after a successful pull.
  8. Security Testing — PASS: The regression test reproduces the same-digest collision and verifies cleanup before each architecture change.
  9. System Security — PASS: Registry validation remains fail-closed. Cleanup cannot move or delete a registry alias.

Files reviewed

  • .github/workflows/managed-images.yaml
  • test/helpers/managed-image-publication-barrier.ts
  • test/managed-image-publication-workflow.test.ts

@prekshivyas
prekshivyas marked this pull request as ready for review July 31, 2026 00:10
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Model comparison: normalized findings match; normalized E2E selections match; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@prekshivyas

Copy link
Copy Markdown
Collaborator Author

Closing as a duplicate of #7951, which merged the managed-image platform-pull cleanup in 0030ba4d3e50a0402a440776f83bace033044937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant