fix(ci): clear managed image platform pulls - #7953
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe managed-image promotion workflow now removes anonymously pulled platform digest references before proceeding. Test infrastructure tracks Docker pulls and validates cleanup ordering, successful promotion, and the expected repeated-pull failure. ChangesManaged image promotion cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit f4ae478 in the TypeScript / code-coverage/cliThe overall coverage in commit f4ae478 in the Show a code coverage summary of the most impacted files.
Updated |
Security reviewVerdictPASS. This change removes a validated digest reference from the GitHub Actions runner-local Docker image store after each anonymous platform pull. It does not change registry aliases, credentials, permissions, or authorization. The PR has no security findings. FindingsNo findings. Detailed analysis
Files reviewed
|
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
|
Closing as a duplicate of #7951, which merged the managed-image platform-pull cleanup in |
Summary
Managed image publication now removes the local digest reference after each anonymous platform pull. This prevents Docker's classic image store from rejecting the next platform pull with
cannot overwrite digestwhile preserving both architecture checks.Changes
Type of Change
Quality Gates
Documentation Writer Review
no-docs-neededDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpx vitest run --project integration test/managed-image-publication-workflow.test.tspassed 12/12 innode:22-bookwormwithjq.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result:npm run docsbuilds without warnings (doc changes only)Signed-off-by: Prekshi Vyas prekshiv@nvidia.com
Summary by CodeRabbit
Bug Fixes
Tests