Skip to content

Clean up stale dataset leftovers#1150

Open
ethany-nv wants to merge 1 commit into
mainfrom
ethany/dataset_leftover_cleanup
Open

Clean up stale dataset leftovers#1150
ethany-nv wants to merge 1 commit into
mainfrom
ethany/dataset_leftover_cleanup

Conversation

@ethany-nv

@ethany-nv ethany-nv commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Remove a few stale dataset leftovers that remained after the main deprecation work landed.

This PR:

  • removes the stale dataset:* default permission from the Helm service chart values
  • removes leftover dataset references from UI scaffolding comments and config
  • updates the osmo-user eval wording to refer to an empty output directory instead of an output dataset

These are follow-up cleanup changes only. They do not restore or remove any additional dataset runtime behavior.

Issue #911

Checklist

  • I am familiar with the Contributing Guidelines.
  • No new tests were needed for this scoped cleanup.
  • The documentation is up to date with these changes.

@ethany-nv ethany-nv requested a review from a team as a code owner June 25, 2026 22:20
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the osmo-user gateway role allow-list, changes one eval question from “output dataset” to “output directory,” removes datasets from UI feature zones, and rewords two inline comments to stop referencing dataset APIs or breadcrumb examples.

Changes

Dataset wording and RBAC updates

Layer / File(s) Summary
Gateway RBAC allow-list
deployments/charts/service/values.yaml
osmo-user's allowed actions replace dataset:* with app:*, auth:Token, and credentials:*.
Eval and comment wording updates
skills/osmo-user/evals/evals.json, src/ui/eslint.config.mjs, src/ui/src/components/chrome/page-context.tsx, src/ui/src/lib/api/adapter/transforms.ts
The eval question, feature-zone list, and inline comments remove or rephrase dataset references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • NVIDIA/OSMO#1138: Also updates osmo-user eval/fixture wording to remove dataset references.
  • NVIDIA/OSMO#1141: Also adjusts Helm/service RBAC action allow-lists to remove dataset-specific permissions.
  • NVIDIA/OSMO#1145: Also changes osmo-user authorization patterns by replacing dataset-scoped actions.

Suggested reviewers

  • cypres
  • fernandol-nvidia
  • RyaliNvidia

Poem

🐰 I hopped through charts and comments light,
and nibbled “dataset” out of sight.
With tokens, apps, and directories clear,
the little bunny tidy work is here.
Hop hop—clean paths now shine so bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the PR’s main cleanup of stale dataset-related leftovers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ethany/dataset_leftover_cleanup

Comment @coderabbitai help to get the list of available commands.

@ethany-nv ethany-nv self-assigned this Jun 25, 2026
@ethany-nv

Copy link
Copy Markdown
Collaborator Author

@elookpotts-nvidia @RyaliNvidia @fernandol-nvidia could you take a look at this cleanup PR when you have a chance? It is a small follow-up to remove stale dataset leftovers after the broader deprecation work landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants