Skip to content

feat(kubernetes): configure sandbox service account token automount#1875

Closed
RohanAdwankar wants to merge 0 commit into
NVIDIA:mainfrom
RohanAdwankar:main
Closed

feat(kubernetes): configure sandbox service account token automount#1875
RohanAdwankar wants to merge 0 commit into
NVIDIA:mainfrom
RohanAdwankar:main

Conversation

@RohanAdwankar

Copy link
Copy Markdown
Member

Summary

Adds an explicit opt-in for Kubernetes sandbox pods to automount their service account token. The default remains hardened (false), but operators can enable it when sandbox-local tools such as kubectl need Kubernetes API access under least-privilege RBAC.

Related Issue

Resolves #1874

Changes

  • Added automount_service_account_token to the Kubernetes driver config, defaulting to false.
  • Added CLI/env support via --automount-service-account-token and OPENSHELL_K8S_AUTOMOUNT_SERVICE_ACCOUNT_TOKEN.
  • Updated sandbox pod rendering to use the configured value instead of hardcoding automountServiceAccountToken: false.
  • Exposed the setting in the Helm chart as server.sandboxAutomountServiceAccountToken.
  • Added Kubernetes driver tests for default-off and explicit opt-in behavior.
  • Updated Kubernetes driver README, Helm README, and reference docs.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@RohanAdwankar RohanAdwankar requested review from a team, derekwaynecarr and mrunalp as code owners June 11, 2026 18:54
@copy-pr-bot

copy-pr-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@RohanAdwankar

Copy link
Copy Markdown
Member Author

Am talking with John on Slack, no rush to review, just wanted to put a draft of what I wanted to do

@RohanAdwankar

Copy link
Copy Markdown
Member Author

I have read the DCO document and I hereby sign the DCO.

@RohanAdwankar RohanAdwankar marked this pull request as draft June 11, 2026 19:00
@RohanAdwankar

Copy link
Copy Markdown
Member Author

recheck

@RohanAdwankar RohanAdwankar marked this pull request as ready for review June 11, 2026 23:22
@RohanAdwankar RohanAdwankar marked this pull request as draft June 25, 2026 20:35
@RohanAdwankar

RohanAdwankar commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Oops didn't realize the merge will request a review, I have one change to make before review, I can ping when ready

@copy-pr-bot

copy-pr-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support opt-in Kubernetes service account token automount for sandbox pods

1 participant