Skip to content

feat(kubernetes): support agent-sandbox v1beta1#2009

Open
TaylorMutch wants to merge 7 commits into
mainfrom
support-agent-sandbox-v1beta1
Open

feat(kubernetes): support agent-sandbox v1beta1#2009
TaylorMutch wants to merge 7 commits into
mainfrom
support-agent-sandbox-v1beta1

Conversation

@TaylorMutch

@TaylorMutch TaylorMutch commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Support both Agent Sandbox agents.x-k8s.io/v1beta1 and agents.x-k8s.io/v1alpha1 APIs so OpenShell works with controller releases still used in the field.

Related Issue

Closes #2013

Changes

  • Detect the served Agent Sandbox API version and use v1beta1 with v1alpha1 fallback.
  • Accept Kubernetes service-account owner references from both v1beta1 and v1alpha1 Sandbox resources.
  • Update Kubernetes E2E coverage to run against both Agent Sandbox API generations.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@TaylorMutch
feat(kubernetes): support agent-sandbox v1beta1
e934f0b 
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch
ci(kubernetes): test agent-sandbox api versions
d0540b2 
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch TaylorMutch added the test:e2e Requires end-to-end coverage label Jun 25, 2026
@TaylorMutch TaylorMutch requested review from a team and derekwaynecarr as code owners June 25, 2026 23:33
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

Label test:e2e applied for d0540b2. Open Branch E2E Checks, find the run for commit d0540b2, and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

🌿 Preview your docs: https://nvidia-preview-pr-2009.docs.buildwithfern.com/openshell

@TaylorMutch
fix(kubernetes): retry agent-sandbox raw 404s
7d2940f 
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
elezar
elezar reviewed Jun 26, 2026
View reviewed changes
Comment thread crates/openshell-driver-kubernetes/src/driver.rs Outdated
elezar
elezar reviewed Jun 26, 2026
View reviewed changes
Comment thread crates/openshell-driver-kubernetes/src/driver.rs Outdated
@TaylorMutch TaylorMutch mentioned this pull request Jun 26, 2026
Open
3 tasks
elezar
elezar reviewed Jun 26, 2026
View reviewed changes
Comment thread crates/openshell-driver-kubernetes/src/driver.rs Outdated
@TaylorMutch
fix(kubernetes): harden agent-sandbox api setup
bb610a5 
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@elezar elezar mentioned this pull request Jun 26, 2026
Open
@TaylorMutch
fix(kubernetes): cache agent-sandbox api version
6471173 
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch
docs(kubernetes): document agent-sandbox upgrade behavior
7f9c1ca 
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch
refactor(kubernetes): collapse agent-sandbox api selection
13f0210 
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
@TaylorMutch TaylorMutch requested a review from elezar June 26, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner
@maxamillion maxamillion Awaiting requested review from maxamillion maxamillion is a code owner
@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr derekwaynecarr is a code owner
@elezar elezar Awaiting requested review from elezar

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OpenShell 0.0.70 sandbox bootstrap failure: IssueSandboxToken rejects pods due to CRD API version mismatch

2 participants

@TaylorMutch @elezar