Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir-tensorrt] Add additional missing StableHLO patch #425

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

christopherbate
Copy link
Collaborator

Added a patch that was missing from the last StableHLO upgrade. This patch
addresses some issues mentioned in openxla/stablehlo#2634.

An additional test is added to mlir-tensorrt as a regression test.

@christopherbate christopherbate force-pushed the fix-missing-stablehlo-patch branch from 9680012 to b918ad2 Compare December 5, 2024 00:48
Added a patch that was missing from the last StableHLO upgrade. This patch
addresses some issues mentioned in openxla/stablehlo#2634.

An additional test is added to mlir-tensorrt as a regression test.

Also makes some minor cleanup to CI/CD config in order to fix the caching
mechanism, using the PR as a test-case.
@christopherbate christopherbate force-pushed the fix-missing-stablehlo-patch branch from b918ad2 to 9fa1e59 Compare December 5, 2024 00:51
@shelkesagar29
Copy link
Collaborator

shelkesagar29 commented Dec 5, 2024

I still see issue with clustering on main. Post clustering validation fails with all stablehlo ops being outside the cluster.

mlir-tensorrt-opt test.mlir -stablehlo-preprocessing-pipeline -stablehlo-clustering-pipeline  -post-clustering-pipeline -executor-lowering-pipeline --mlir-elide-elementsattrs-if-larger=32

Is above command invalid now?
test.mlir has IR from one of the Tripy issues.

@christopherbate
Copy link
Collaborator Author

I still see issue with clustering on main. Post clustering validation fails with all stablehlo ops being outside the cluster.

mlir-tensorrt-opt test.mlir -stablehlo-preprocessing-pipeline -stablehlo-clustering-pipeline  -post-clustering-pipeline -executor-lowering-pipeline --mlir-elide-elementsattrs-if-larger=32

Is above command invalid now? test.mlir has IR from one of the Tripy issues.

That's because you're forgetting to add the top-level "plan.cluster_kinds" attribute to the module. See the commit log here a1ccbe6 (this was a combination of two internal commits, the second one is relevant). See the internal commit "Update how cluster kinds and their options are populated" if you want to look at the changes in isolation.

@christopherbate christopherbate merged commit fb85968 into main Dec 5, 2024
1 check passed
@christopherbate christopherbate deleted the fix-missing-stablehlo-patch branch December 5, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants