Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TE/JAX] Custom call with FFI - lowering all attributes with bind all #1289

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

phu0ngng
Copy link
Collaborator

Description

Lowering all attributes with bind all in FusedAttnFwd.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sorry, something went wrong.

@phu0ngng phu0ngng requested a review from huanghua1994 October 25, 2024 17:30
@phu0ngng
Copy link
Collaborator Author

/te-ci jax

Copy link
Collaborator

@huanghua1994 huanghua1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- improve err message with line and func info

- calculate ws size with product

Signed-off-by: Phuong Nguyen <[email protected]>
for more information, see https://pre-commit.ci
@phu0ngng
Copy link
Collaborator Author

/te-ci jax

Signed-off-by: Phuong Nguyen <[email protected]>
@phu0ngng
Copy link
Collaborator Author

/te-ci jax

Signed-off-by: Phuong Nguyen <[email protected]>
for more information, see https://pre-commit.ci
Copy link
Collaborator

@zlsh80826 zlsh80826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phu0ngng phu0ngng merged commit 9dddb36 into NVIDIA:main Oct 31, 2024
15 checks passed
@phu0ngng phu0ngng deleted the ffi_dict_attrs branch October 31, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants