Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Respect existing quantizer usages in functional linear API #1440

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

timmoon10
Copy link
Collaborator

Description

As part of the 2.0 refactor, we exposed quantizers in the functional linear API (BasicLinear._functional_forward/BasicLinear._functional_backward). These functions internally set the quantizer usages so that the GEMMs have the data they need, but I didn't consider a case where the weight quantizer has an extra usage (i.e. so we can cache it for the backward pass). This PR modifies the functional linear API so it only sets the required usages and doesn't wipe out any user-provided usages.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Respect existing quantizer usages in functional linear API

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10 timmoon10 added bug Something isn't working 2.0.0 labels Jan 30, 2025
@timmoon10 timmoon10 merged commit 5904a80 into NVIDIA:release_v2.0 Jan 30, 2025
9 of 11 checks passed
@timmoon10 timmoon10 deleted the debug-functional-linear branch January 30, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant