Fix test of FSDP2 by correcting init logic and applying autocast #2105
+10
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes multiple issues in the FSDP2 test, namely
args.fp8_init == False
. I have updated the logic to match what I presume was intended by leveraging the nullcontext context manager.te.fp8_autocast
was previously not called; the recipe was created but was unused. The autocast context manager now wraps the model's computation.Does not necessarily fix #1705, but it does enable the test which should determine if the issue is still present.
Type of change
Changes
Please list the changes introduced in this PR:
fp8_model_init
according to the test's flagfp8_autocast
Checklist: