[JAX] Fix failing fused attn tests for dropout=0.1 and bias for sm100 #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KshitijLakhani
force-pushed
the
klakhani/fix/jax-dropout-bias-sm100-test-failures
branch
from
a85ad4f to
330ffd5
Compare
KshitijLakhani
force-pushed
the
klakhani/fix/jax-dropout-bias-sm100-test-failures
branch
from
cd1b8c9 to
4a2a993
Compare
KshitijLakhani
changed the title
KshitijLakhani
requested review from
phu0ngng and
cyanguwa
and removed request for
phu0ngng
|
#34107254 Launched a pipeline as I needed to alter the JAX image for testing. |
KshitijLakhani
force-pushed
the
klakhani/fix/jax-dropout-bias-sm100-test-failures
branch
from
942d624 to
319807a
Compare
|
/te-ci jax |
Signed-off-by: Kshitij Lakhani <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Kshitij Lakhani <[email protected]>
Signed-off-by: Kshitij Lakhani <[email protected]> Add check for sm100 Signed-off-by: Kshitij Lakhani <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Kshitij Lakhani <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Kshitij Lakhani <[email protected]>
…g unnecessary type conversion Signed-off-by: Kshitij Lakhani <[email protected]>
Signed-off-by: Kshitij Lakhani <[email protected]>
KshitijLakhani
force-pushed
the
klakhani/fix/jax-dropout-bias-sm100-test-failures
branch
from
1ac4bd5 to
b76131c
Compare
KshitijLakhani
deleted the
klakhani/fix/jax-dropout-bias-sm100-test-failures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cuDNN kernel path to allow for dropout along with determinism (for bias) is unsupported as of now on sm100 resulting in failures. This PR helps fix this.
I confirmed that 78 test failures were seen in the JAX nightly are now being skipped in the pipeline run for this PR and that there are no new additional skips due to the logic in the PR.
Type of change
Changes
i) Skips the fused attn tests so as to not try and exercise the unsupported path.
ii) Puts an assert in place in fused attn bwd to guard against inadvertent usage of the unsupported path
Checklist: