You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The slinky-slurm-operator component does not honor AICR's --system-node-selector flag because the upstream Slinky chart v1.1.0 silently ignores operator.nodeSelector and webhook.nodeSelector. Once SlinkyProject/slurm-operator#187 merges and a new chart version is published, AICR can wire the nodeSelector paths and bump the chart pin.
Background
Reproduction with slurm-operator chart v1.1.0:
helm pull oci://ghcr.io/slinkyproject/charts/slurm-operator --version 1.1.0
helm template slinky-slurm-op slurm-operator-1.1.0.tgz \
--set operator.nodeSelector.foo=bar \
--set webhook.nodeSelector.baz=qux | grep nodeSelector
# (no output — value silently discarded; chart templates only render# operator.{affinity,tolerations} and webhook.{affinity,tolerations})
This causes AICR's --system-node-selector flag to be a no-op for this component until upstream adds the templating. The current registry comment (recipes/registry.yaml under slinky-slurm-operator > nodeScheduling > system) documents the limitation, links the upstream PR, and includes the verbatim follow-up action.
Remove the # Setting operator.nodeSelector / webhook.nodeSelector is silently dropped... comment block (it becomes obsolete).
Verify against a live cluster:
make check-health COMPONENT=slinky-slurm-operator
aicr bundle ... --system-node-selector key=value
helm template <bundled-chart-path>/slinky-slurm-operator | grep -A2 nodeSelector
# expect: operator and webhook deployments both carry the nodeSelector
Verification
make qualify — must pass.
Live smoke: install slurm-operator on a Kind cluster with --set operator.nodeSelector.kubernetes.io/os=linux, confirm the deployment carries the selector.
Prerequisites
Summary
The
slinky-slurm-operatorcomponent does not honor AICR's--system-node-selectorflag because the upstream Slinky chart v1.1.0 silently ignoresoperator.nodeSelectorandwebhook.nodeSelector. Once SlinkyProject/slurm-operator#187 merges and a new chart version is published, AICR can wire the nodeSelector paths and bump the chart pin.Background
Reproduction with
slurm-operatorchart v1.1.0:This causes AICR's
--system-node-selectorflag to be a no-op for this component until upstream adds the templating. The current registry comment (recipes/registry.yaml underslinky-slurm-operator > nodeScheduling > system) documents the limitation, links the upstream PR, and includes the verbatim follow-up action.Action items (once SlinkyProject/slurm-operator#187 merges and ships)
recipes/registry.yamlslinky-slurm-operator > helm > defaultVersionfrom"1.1.0"to the chart version that includes Expose nodeSelector for operator and webhook SlinkyProject/slurm-operator#187.nodeScheduling > system, add:# Setting operator.nodeSelector / webhook.nodeSelector is silently dropped...comment block (it becomes obsolete).Verification
make qualify— must pass.--set operator.nodeSelector.kubernetes.io/os=linux, confirm the deployment carries the selector.Problem/Use Case
AICR Slinky slurm-operator
Proposed Solution
Track SlinkyProject/slurm-operator#187 and apply changes to AICR when it lands
Success Criteria
Apply changes to AICR when SlinkyProject/slurm-operator#187 lands
Alternatives Considered
No response
Component
New component
Priority
Important (would improve my workflow)
Compatibility / Breaking Changes
No response
Operational Considerations
No response
Are you willing to contribute?
Yes, I can open a PR