fix: enforce error handling, polling, and deletion policy patterns - #215
Merged
Conversation
Replace fmt.Errorf with pkg/errors structured errors in bundler validations. Wrap bare error returns in k8s/agent, validator/agent, and deployment checks. Replace raw time.NewTicker polling with wait.PollUntilContextCancel in WaitForPodReady. Standardize Job deletion to foreground propagation across both agent packages.
lalitadithya
approved these changes
Feb 25, 2026
Contributor
|
This pull request has been automatically locked since it has been closed for 90 days with no further activity. Please open a new pull request for related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fmt.Errorfwithpkg/errorsstructured errors in bundler validationspkg/k8s/agent,pkg/validator/agent, and deployment checkstime.NewTickerpolling withwait.PollUntilContextCancelinWaitForPodReadygofmtlint failure in conformance test helpersTest plan
make testpasses (all packages, race detector enabled)make lintpasses (0 issues)make qualifypasses (test + lint + e2e + scan)