Skip to content

docs(defaults): correct MirrorDefaultKubeVersion rationale comment #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuanchen8911 wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −2
Open

docs(defaults): correct MirrorDefaultKubeVersion rationale comment #2336

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47fbd07
docs(defaults): correct MirrorDefaultKubeVersion rationale comment
yuanchen8911 Aug 21, 2026
3bf7702
docs(defaults): scope the kube-version invariant to the constant
yuanchen8911 Aug 21, 2026
db1ada7
Merge branch 'main' into fix/mirror-kube-version-comment
mchmarny Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pkg/defaults/timeouts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,8 +1254,18 @@ const (
// recipe constraints. Without this flag Helm uses its compiled-in
// default (currently v1.27.0 in Helm 3.x), which is too old for
// charts that declare a kubeVersion constraint (e.g., >=1.32.0-0).
// The value tracks the project's minimum supported Kubernetes version
// declared in recipes/overlays/base.yaml.
//
// This is a render-safe fallback, not a support floor. This constant
// must stay at or above the strictest kubeVersion any bundled chart
// declares. Do NOT lower it to match the ">= 1.25" recipe floor in
// recipes/overlays/base.yaml: that is the constraint recipes are
// validated against, and a recipe that declares one never reaches this
Comment thread
yuanchen8911 marked this conversation as resolved.
// default (see mirror.KubeVersionFromConstraints).
Comment thread
yuanchen8911 marked this conversation as resolved.
//
// The invariant binds this constant only. The constraint path is
// unbounded below: KubeVersionFromConstraints returns the recipe's own
// value, so a recipe carrying nothing but base.yaml's ">= 1.25" renders
// with --kube-version 1.25.
MirrorDefaultKubeVersion = "1.33.0"

// MirrorDiscoveryConcurrency caps the number of components rendered in
Expand Down
Loading